From 3876a417cd0bb5ffd1e530d7768ac91612e5184d Mon Sep 17 00:00:00 2001 From: Alfy Date: Tue, 3 Jan 2017 21:02:50 +0300 Subject: [PATCH] Added types to functions for FlexSlider (#13708) * Changed noImplicitAny to true * Added any type to the functions * Fixed failing tests * Changed canAdvance to return a boolean --- flexslider/flexSlider-tests.ts | 4 ++-- flexslider/index.d.ts | 12 ++++++------ flexslider/tsconfig.json | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/flexslider/flexSlider-tests.ts b/flexslider/flexSlider-tests.ts index 2369ce9b31..591e874262 100644 --- a/flexslider/flexSlider-tests.ts +++ b/flexslider/flexSlider-tests.ts @@ -62,7 +62,7 @@ $(window).load(function() { var player = document.getElementById('player_1'); $(player).on('ready', ready); - function addEvent(element, eventName, callback) { + function addEvent(element:any, eventName:any, callback:any) { if (element.addEventListener) { element.addEventListener(eventName, callback, false) } else { @@ -70,7 +70,7 @@ $(window).load(function() { } } - function ready(player_id) { + function ready(player_id: any) { var froogaloop = $(player_id); froogaloop.on('play', function(data) { $('.flexslider').flexslider("pause"); diff --git a/flexslider/index.d.ts b/flexslider/index.d.ts index c15d5d59be..9767744919 100644 --- a/flexslider/index.d.ts +++ b/flexslider/index.d.ts @@ -18,11 +18,11 @@ interface SliderObject { //Object: The slider element itself directionNav: Object; //Object: The slider directionNav controlsContainer: Object; //Object: The controlsContainer element of the slider manualControls: Object; //Object: The manualControls element of the slider - flexAnimate(target, pause?); //Function: Move slider - (target, pause) parameters - pause(); //Function: Pause slider slideshow interval - resume(); //Function: Resume slider slideshow interval - canAdvance(target); //Function: returns boolean if slider can advance - (target) parameter - getTarget(dir); //Function: get target given a direction - "next" or "prev" parameter + flexAnimate(target:any, pause?: any) :any; //Function: Move slider - (target, pause) parameters + pause(): any; //Function: Pause slider slideshow interval + resume(): any; //Function: Resume slider slideshow interval + canAdvance(target:any): boolean; //Function: returns boolean if slider can advance - (target) parameter + getTarget(dir: any): any; //Function: get target given a direction - "next" or "prev" parameter } interface FlexSliderOptions { @@ -86,5 +86,5 @@ interface FlexSliderOptions { interface JQuery { - flexslider(options?: FlexSliderOptions); + flexslider(options?: FlexSliderOptions): any; } diff --git a/flexslider/tsconfig.json b/flexslider/tsconfig.json index c34db7d4d9..2319b11528 100644 --- a/flexslider/tsconfig.json +++ b/flexslider/tsconfig.json @@ -2,7 +2,7 @@ "compilerOptions": { "module": "commonjs", "target": "es6", - "noImplicitAny": false, + "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": false, "baseUrl": "../",