From 388a49ca6cf64a35de7b9cc49333ec175ac16dd8 Mon Sep 17 00:00:00 2001 From: Wesley Wigham Date: Thu, 11 Apr 2019 18:02:03 -0700 Subject: [PATCH] Enable strict null checks on reflux --- types/reflux/reflux-tests.tsx | 2 +- types/reflux/tsconfig.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/types/reflux/reflux-tests.tsx b/types/reflux/reflux-tests.tsx index b4303c6901..dd00c900c8 100644 --- a/types/reflux/reflux-tests.tsx +++ b/types/reflux/reflux-tests.tsx @@ -48,7 +48,7 @@ Reflux.createAction({ let action = Reflux.createAction(); action = Reflux.createAction({ children: ['delayComplete'] }); action = Reflux.createAction({ actionName: 'load' }); -action = Reflux.createAction({ preEmit: (id: number) => { console.log(id); }, shouldEmit: (id: number) => { console.log(id); return id > 0; } }); +action = Reflux.createAction({ preEmit: (id: number) => { console.log(id); return undefined; }, shouldEmit: (id: number) => { console.log(id); return id > 0; } }); let actions = Reflux.createActions([{ actionName: 'fireBall' }, { actionName: 'magicMissile', sync: false }]); actions = Reflux.createActions({ fireBall: { sync: false } }); diff --git a/types/reflux/tsconfig.json b/types/reflux/tsconfig.json index d51658ce93..3f06615fd2 100644 --- a/types/reflux/tsconfig.json +++ b/types/reflux/tsconfig.json @@ -7,7 +7,7 @@ ], "noImplicitAny": true, "noImplicitThis": true, - "strictNullChecks": false, + "strictNullChecks": true, "strictFunctionTypes": true, "baseUrl": "../", "jsx": "react",