From 3d9e9bbdb79169eb476c5b1f856123dfa35968f0 Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Date: Mon, 30 Sep 2019 13:13:34 -0700 Subject: [PATCH] Update react-dnd-touch-backend dnd-core dependency (#38734) * Update react-dnd-touch-backend dnd-core dependency dnd-core dependency goes from 4.5 to 9.3.1. 9.3.1 is the first version that fixes an incorrect export that is now detected by Typescript 3.7. I'm not sure this is the best fix, but I don't see a way to create a new release of dnd-core@4.x either. * remove react-dnd-touch-backend --- notNeededPackages.json | 6 +++ types/react-dnd-touch-backend/index.d.ts | 50 ------------------- types/react-dnd-touch-backend/package.json | 6 --- .../react-dnd-touch-backend-tests.ts | 17 ------- types/react-dnd-touch-backend/tsconfig.json | 24 --------- types/react-dnd-touch-backend/tslint.json | 1 - 6 files changed, 6 insertions(+), 98 deletions(-) delete mode 100644 types/react-dnd-touch-backend/index.d.ts delete mode 100644 types/react-dnd-touch-backend/package.json delete mode 100644 types/react-dnd-touch-backend/react-dnd-touch-backend-tests.ts delete mode 100644 types/react-dnd-touch-backend/tsconfig.json delete mode 100644 types/react-dnd-touch-backend/tslint.json diff --git a/notNeededPackages.json b/notNeededPackages.json index c0d0abf55d..40d8066655 100644 --- a/notNeededPackages.json +++ b/notNeededPackages.json @@ -2886,6 +2886,12 @@ "sourceRepoURL": "https://github.com/react-dnd/react-dnd", "asOfVersion": "3.0.2" }, + { + "libraryName": "react-dnd-touch-backend", + "typingsPackageName": "react-dnd-touch-backend", + "sourceRepoURL": "https://github.com/react-dnd/react-dnd", + "asOfVersion": "0.5.0" + }, { "libraryName": "react-dropzone", "typingsPackageName": "react-dropzone", diff --git a/types/react-dnd-touch-backend/index.d.ts b/types/react-dnd-touch-backend/index.d.ts deleted file mode 100644 index e06a4106e7..0000000000 --- a/types/react-dnd-touch-backend/index.d.ts +++ /dev/null @@ -1,50 +0,0 @@ -// Type definitions for react-dnd-touch-backend 0.4 -// Project: https://github.com/yahoo/react-dnd-touch-backend#readme -// Definitions by: Daniel Król , -// Janeene Beeforth -// Adam Haglund -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// TypeScript Version: 2.8 - -import { BackendFactory } from 'dnd-core'; - -export default function createTouchBackend(option?: TouchBackendOptions): BackendFactory; - -export interface TouchBackendOptions { - /** - * Support mouse events as well as touch events. - */ - enableMouseEvents?: boolean; - /** - * Can cancel drag by hitting Escape if enableKeyboardEvents option is set to true - */ - enableKeyboardEvents?: boolean; - /** - * Number of milliseconds that the item needs to be touched before the touch is considered the start of a drag. - * This is used to allow both flick-to-scroll and drag-n-drop on objects in a list. - */ - delayTouchStart?: number; - /** - * Number of milliseconds that the item needs to be clicked on before the click is considered the start of a drag. - */ - delayMouseStart?: number; - /** - * Number of milliseconds delay before the touch/click is considered a drag. - * @deprecated replaced by delayTouchStart and delayMouseStart, but is still supported at present. - */ - delay?: number; - /** - * Specifies the pixel distance moved before a drag is signaled. Default 0. - */ - touchSlop?: number; - /** - * If true, prevents the contextmenu event from canceling a drag. Default false. - */ - ignoreContextMenu?: boolean; - /** - * Specifies ranges of angles in degrees that drag events should be ignored. This is useful when you want to allow - * the user to scroll in a particular direction instead of dragging. Degrees move clockwise, 0/360 pointing to the - * left. Default: undefined - */ - scrollAngleRanges?: ReadonlyArray<{ start?: number, end?: number }>; -} diff --git a/types/react-dnd-touch-backend/package.json b/types/react-dnd-touch-backend/package.json deleted file mode 100644 index 7f98b8bee8..0000000000 --- a/types/react-dnd-touch-backend/package.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "private": true, - "dependencies": { - "dnd-core": "^4.0.5" - } -} diff --git a/types/react-dnd-touch-backend/react-dnd-touch-backend-tests.ts b/types/react-dnd-touch-backend/react-dnd-touch-backend-tests.ts deleted file mode 100644 index 77da6f241f..0000000000 --- a/types/react-dnd-touch-backend/react-dnd-touch-backend-tests.ts +++ /dev/null @@ -1,17 +0,0 @@ -import { createDragDropManager } from "dnd-core"; -import TouchBackend from "react-dnd-touch-backend"; - -const context = {}; - -const dndComponent = createDragDropManager(TouchBackend(), context); -const dndComponentMouseEvents = createDragDropManager(TouchBackend({enableMouseEvents: true}), context); -const dndComponentDelayTouchStart = createDragDropManager(TouchBackend({delayTouchStart: 200}), context); -const dndComponentDelayMouseStart = createDragDropManager(TouchBackend({enableMouseEvents: true, delayMouseStart: 100}), context); -const dndComponentKeyboardEvents = createDragDropManager(TouchBackend({enableKeyboardEvents: true}), context); -const dndComponentOldDelay = createDragDropManager(TouchBackend({delay: 300}), context); -const dndComponentAllCurrentEvents = createDragDropManager(TouchBackend( - {enableKeyboardEvents: true, enableMouseEvents: true, delayMouseStart: 100, delayTouchStart: 200}), context); -const dndComponentWithScrollAngleRanges = createDragDropManager(TouchBackend( - { scrollAngleRanges: [{ start: 0, end: 0 }, { start: 0 }, { end: 0 }] }), context); -const dndComponentWithTouchSlop = createDragDropManager(TouchBackend({ touchSlop: 0 }), context); -const dndComponentWithIgnoreContextMenu = createDragDropManager(TouchBackend({ ignoreContextMenu: true }), context); diff --git a/types/react-dnd-touch-backend/tsconfig.json b/types/react-dnd-touch-backend/tsconfig.json deleted file mode 100644 index de3b6da377..0000000000 --- a/types/react-dnd-touch-backend/tsconfig.json +++ /dev/null @@ -1,24 +0,0 @@ -{ - "compilerOptions": { - "module": "commonjs", - "lib": [ - "es6", - "dom" - ], - "noImplicitAny": true, - "noImplicitThis": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "baseUrl": "../", - "typeRoots": [ - "../" - ], - "types": [], - "noEmit": true, - "forceConsistentCasingInFileNames": true - }, - "files": [ - "index.d.ts", - "react-dnd-touch-backend-tests.ts" - ] -} \ No newline at end of file diff --git a/types/react-dnd-touch-backend/tslint.json b/types/react-dnd-touch-backend/tslint.json deleted file mode 100644 index 3db14f85ea..0000000000 --- a/types/react-dnd-touch-backend/tslint.json +++ /dev/null @@ -1 +0,0 @@ -{ "extends": "dtslint/dt.json" }