From 31519390e922b1ac830ed6ca56dbd67b9d3af5a4 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Fri, 14 Sep 2018 13:52:12 -0700 Subject: [PATCH 1/2] `node`: [fix] node buffers have a `constructor` property --- types/node/index.d.ts | 1 + types/node/v0/index.d.ts | 1 + types/node/v4/index.d.ts | 1 + types/node/v6/index.d.ts | 1 + types/node/v7/index.d.ts | 1 + types/node/v8/index.d.ts | 1 + types/node/v9/index.d.ts | 1 + 7 files changed, 7 insertions(+) diff --git a/types/node/index.d.ts b/types/node/index.d.ts index c1974ef350..a1e7642bd4 100644 --- a/types/node/index.d.ts +++ b/types/node/index.d.ts @@ -270,6 +270,7 @@ declare var SlowBuffer: { // Buffer class type BufferEncoding = "ascii" | "utf8" | "utf16le" | "ucs2" | "base64" | "latin1" | "binary" | "hex"; interface Buffer extends Uint8Array { + constructor: typeof Buffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] }; diff --git a/types/node/v0/index.d.ts b/types/node/v0/index.d.ts index 3bc1b3ed5d..2b07bae33c 100644 --- a/types/node/v0/index.d.ts +++ b/types/node/v0/index.d.ts @@ -379,6 +379,7 @@ declare namespace NodeJS { * @deprecated */ interface NodeBuffer { + constructor: typeof NodeBuffer; [index: number]: number; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; diff --git a/types/node/v4/index.d.ts b/types/node/v4/index.d.ts index 6ebd6b2839..33e787cd94 100644 --- a/types/node/v4/index.d.ts +++ b/types/node/v4/index.d.ts @@ -564,6 +564,7 @@ declare namespace NodeJS { * @deprecated */ interface NodeBuffer extends Uint8Array { + constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): {type: 'Buffer', data: any[]}; diff --git a/types/node/v6/index.d.ts b/types/node/v6/index.d.ts index 8a9ee77904..6bdea3024b 100644 --- a/types/node/v6/index.d.ts +++ b/types/node/v6/index.d.ts @@ -622,6 +622,7 @@ interface IterableIterator { } * @deprecated */ interface NodeBuffer extends Uint8Array { + constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] }; diff --git a/types/node/v7/index.d.ts b/types/node/v7/index.d.ts index 11dc0e4f5a..9d677ce637 100644 --- a/types/node/v7/index.d.ts +++ b/types/node/v7/index.d.ts @@ -619,6 +619,7 @@ interface IterableIterator { } * @deprecated */ interface NodeBuffer extends Uint8Array { + constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] }; diff --git a/types/node/v8/index.d.ts b/types/node/v8/index.d.ts index 4cf8dc2a78..bf28c464b4 100644 --- a/types/node/v8/index.d.ts +++ b/types/node/v8/index.d.ts @@ -819,6 +819,7 @@ interface IterableIterator { } * @deprecated */ interface NodeBuffer extends Uint8Array { + constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] }; diff --git a/types/node/v9/index.d.ts b/types/node/v9/index.d.ts index e1b44f5602..0c77d826b9 100644 --- a/types/node/v9/index.d.ts +++ b/types/node/v9/index.d.ts @@ -260,6 +260,7 @@ declare var SlowBuffer: { // Buffer class type BufferEncoding = "ascii" | "utf8" | "utf16le" | "ucs2" | "base64" | "latin1" | "binary" | "hex"; interface Buffer extends Uint8Array { + constructor: typeof Buffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] }; From 461d2d5dfa3fbbe7b6a8322939d840a97e7a6e50 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Fri, 14 Sep 2018 14:25:57 -0700 Subject: [PATCH 2/2] revert < v9 changes, since they lack a type for the constructor itself --- types/node/v0/index.d.ts | 1 - types/node/v4/index.d.ts | 1 - types/node/v6/index.d.ts | 1 - types/node/v7/index.d.ts | 1 - types/node/v8/index.d.ts | 1 - 5 files changed, 5 deletions(-) diff --git a/types/node/v0/index.d.ts b/types/node/v0/index.d.ts index 2b07bae33c..3bc1b3ed5d 100644 --- a/types/node/v0/index.d.ts +++ b/types/node/v0/index.d.ts @@ -379,7 +379,6 @@ declare namespace NodeJS { * @deprecated */ interface NodeBuffer { - constructor: typeof NodeBuffer; [index: number]: number; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; diff --git a/types/node/v4/index.d.ts b/types/node/v4/index.d.ts index 33e787cd94..6ebd6b2839 100644 --- a/types/node/v4/index.d.ts +++ b/types/node/v4/index.d.ts @@ -564,7 +564,6 @@ declare namespace NodeJS { * @deprecated */ interface NodeBuffer extends Uint8Array { - constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): {type: 'Buffer', data: any[]}; diff --git a/types/node/v6/index.d.ts b/types/node/v6/index.d.ts index 6bdea3024b..8a9ee77904 100644 --- a/types/node/v6/index.d.ts +++ b/types/node/v6/index.d.ts @@ -622,7 +622,6 @@ interface IterableIterator { } * @deprecated */ interface NodeBuffer extends Uint8Array { - constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] }; diff --git a/types/node/v7/index.d.ts b/types/node/v7/index.d.ts index 9d677ce637..11dc0e4f5a 100644 --- a/types/node/v7/index.d.ts +++ b/types/node/v7/index.d.ts @@ -619,7 +619,6 @@ interface IterableIterator { } * @deprecated */ interface NodeBuffer extends Uint8Array { - constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] }; diff --git a/types/node/v8/index.d.ts b/types/node/v8/index.d.ts index bf28c464b4..4cf8dc2a78 100644 --- a/types/node/v8/index.d.ts +++ b/types/node/v8/index.d.ts @@ -819,7 +819,6 @@ interface IterableIterator { } * @deprecated */ interface NodeBuffer extends Uint8Array { - constructor: typeof NodeBuffer; write(string: string, offset?: number, length?: number, encoding?: string): number; toString(encoding?: string, start?: number, end?: number): string; toJSON(): { type: 'Buffer', data: any[] };