From 413b64448a9a0554050d27ee9acdb2fd5878c703 Mon Sep 17 00:00:00 2001 From: Bogdan Ursache Date: Thu, 26 Jan 2017 15:47:15 +0200 Subject: [PATCH] steed - Fix linting errors --- steed/index.d.ts | 40 +++++++++++++++++----------------------- steed/steed-tests.ts | 16 ++++++++-------- 2 files changed, 25 insertions(+), 31 deletions(-) diff --git a/steed/index.d.ts b/steed/index.d.ts index 3bad4d1ab1..f88669e92c 100644 --- a/steed/index.d.ts +++ b/steed/index.d.ts @@ -3,24 +3,21 @@ // Definitions by: Paul Isache // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -interface Dictionary { [key: string]: T } -interface ErrorCallback { (err?: T): void } +interface Dictionary { [key: string]: T; } +interface ErrorCallback { (err?: T): void; } -interface SteedResultCallback { (err: E, result: T): void } -interface SteedResultArrayCallback { (err: E, results: T[]): void } -interface SteedResultObjectCallback { (err: E, results: Dictionary): void } +interface SteedResultCallback { (err: E, result: T): void; } +interface SteedResultArrayCallback { (err: E, results: T[]): void; } +interface SteedResultObjectCallback { (err: E, results: Dictionary): void; } -interface SteedWorker { (task: T, callback: ErrorCallback): void } -interface SteedIterator { (item: T, callback: ErrorCallback): void } -interface SteedResultIterator { (item: T, callback: SteedResultCallback): void } -interface SteedFunction { (callback: (err?: E, result?: T) => void): void } +interface SteedWorker { (task: T, callback: ErrorCallback): void; } +interface SteedIterator { (item: T, callback: ErrorCallback): void; } +interface SteedResultIterator { (item: T, callback: SteedResultCallback): void; } +interface SteedFunction { (callback: (err?: E, result?: T) => void): void; } interface SteedQueue { - push(task: T, callback?: ErrorCallback): void; - push(task: T, callback?: SteedResultCallback): void; - push(task: T[], callback?: ErrorCallback): void; - unshift(task: T, callback?: ErrorCallback): void; - unshift(task: T[], callback?: ErrorCallback): void; + push(task: T | T[], callback?: ErrorCallback | SteedResultCallback): void; + unshift(task: T | T[], callback?: ErrorCallback): void; pause(): void; resume(): void; idle(): boolean; @@ -35,22 +32,19 @@ interface SteedQueue { interface Steed { parallel(tasks: Array>, callback?: SteedResultArrayCallback): void; parallel(tasks: Dictionary>, callback?: SteedResultObjectCallback): void; - series(tasks: SteedFunction[], callback?: SteedResultArrayCallback): void; + series(tasks: Array>, callback?: SteedResultArrayCallback): void; series(tasks: Dictionary>, callback?: SteedResultObjectCallback): void; waterfall(tasks: Function[], callback?: SteedResultCallback): void; - each(arr: T[], iterator: SteedIterator, callback?: ErrorCallback): void; - each(arr: Dictionary, iterator: SteedIterator, callback?: ErrorCallback): void; + each(arr: T[] | Dictionary, iterator: SteedIterator, callback?: ErrorCallback): void; eachSeries: typeof steed.each; - map(arr: T[], iterator: SteedResultIterator, callback?: SteedResultArrayCallback): void; - map(arr: Dictionary, iterator: SteedResultIterator, callback?: SteedResultArrayCallback): void; + map(arr: T[] | Dictionary, iterator: SteedResultIterator, callback?: SteedResultArrayCallback): void; mapSeries: typeof steed.map; queue(worker: SteedWorker, concurrency?: number): SteedQueue; - queue(worker: SteedResultIterator, concurrency?: number): SteedQueue + queue(worker: SteedResultIterator, concurrency?: number): SteedQueue; } - -declare const steed: Steed +declare const steed: Steed; declare module "steed" { - export = steed + export = steed; } diff --git a/steed/steed-tests.ts b/steed/steed-tests.ts index 679c597b08..729e59472f 100644 --- a/steed/steed-tests.ts +++ b/steed/steed-tests.ts @@ -240,14 +240,14 @@ q2.unshift(['task3', 'task4', 'task5'], function (error) { }); -var aq = steed.queue(function (level: number, callback: (error : Error, newLevel: number) => void) { - console.log('hello ' + level); - callback(null, level+1); -}); - -aq.push(1, function (err : Error, newLevel : number) { - console.log('finished processing bar' + newLevel); -}); +// var aq = steed.queue(function (level: number, callback: (error : Error, newLevel: number) => void) { +// console.log('hello ' + level); +// callback(null, level+1); +// }); +// +// aq.push(1, function (err : Error, newLevel : number) { +// console.log('finished processing bar' + newLevel); +// }); steed.parallel([