From 4227df17efcf3f528dbb10dcf69f09a24aa0336a Mon Sep 17 00:00:00 2001 From: Chris Bajorin Date: Fri, 28 Feb 2020 13:47:51 -0500 Subject: [PATCH] =?UTF-8?q?node/tty=20-=20as=20of=20v10,=20readStream.setR?= =?UTF-8?q?awMode(mode)=20returns=20'thi=E2=80=A6=20(#41194)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * node/tty - as of v10, readStream.setRawMode(mode) returns 'this' instead of 'void' * node/tty revert v11 changes * node/tty updated v12 for setRawMode --- types/node/test/tty.ts | 2 +- types/node/tty.d.ts | 2 +- types/node/v10/node-tests.ts | 2 +- types/node/v10/tty.d.ts | 2 +- types/node/v12/test/tty.ts | 2 +- types/node/v12/tty.d.ts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/types/node/test/tty.ts b/types/node/test/tty.ts index c34824c72e..c44f5c9647 100644 --- a/types/node/test/tty.ts +++ b/types/node/test/tty.ts @@ -5,7 +5,7 @@ const rs: tty.ReadStream = new tty.ReadStream(0); const ws: tty.WriteStream = new tty.WriteStream(1); const rsIsRaw: boolean = rs.isRaw; -rs.setRawMode(true); +const rawRs: tty.ReadStream = rs.setRawMode(true); const wsColumns: number = ws.columns; const wsRows: number = ws.rows; diff --git a/types/node/tty.d.ts b/types/node/tty.d.ts index 22bce21a33..7854366339 100644 --- a/types/node/tty.d.ts +++ b/types/node/tty.d.ts @@ -5,7 +5,7 @@ declare module "tty" { class ReadStream extends net.Socket { constructor(fd: number, options?: net.SocketConstructorOpts); isRaw: boolean; - setRawMode(mode: boolean): void; + setRawMode(mode: boolean): this; isTTY: boolean; } /** diff --git a/types/node/v10/node-tests.ts b/types/node/v10/node-tests.ts index 0a73d8cda7..da009ba51d 100644 --- a/types/node/v10/node-tests.ts +++ b/types/node/v10/node-tests.ts @@ -2221,7 +2221,7 @@ async function asyncStreamPipelineFinished() { const ws: tty.WriteStream = new tty.WriteStream(1); const rsIsRaw: boolean = rs.isRaw; - rs.setRawMode(true); + const rsRaw: tty.ReadStream = rs.setRawMode(true); const wsColumns: number = ws.columns; const wsRows: number = ws.rows; diff --git a/types/node/v10/tty.d.ts b/types/node/v10/tty.d.ts index f7b8281dfa..55c0c36cd0 100644 --- a/types/node/v10/tty.d.ts +++ b/types/node/v10/tty.d.ts @@ -5,7 +5,7 @@ declare module "tty" { class ReadStream extends net.Socket { constructor(fd: number, options?: net.SocketConstructorOpts); isRaw: boolean; - setRawMode(mode: boolean): void; + setRawMode(mode: boolean): this; isTTY: boolean; } class WriteStream extends net.Socket { diff --git a/types/node/v12/test/tty.ts b/types/node/v12/test/tty.ts index 071b2c6a7d..9f1f06ba0e 100644 --- a/types/node/v12/test/tty.ts +++ b/types/node/v12/test/tty.ts @@ -4,7 +4,7 @@ const rs: tty.ReadStream = new tty.ReadStream(0); const ws: tty.WriteStream = new tty.WriteStream(1); const rsIsRaw: boolean = rs.isRaw; -rs.setRawMode(true); +const rawRs: tty.ReadStream = rs.setRawMode(true); const wsColumns: number = ws.columns; const wsRows: number = ws.rows; diff --git a/types/node/v12/tty.d.ts b/types/node/v12/tty.d.ts index 22bce21a33..7854366339 100644 --- a/types/node/v12/tty.d.ts +++ b/types/node/v12/tty.d.ts @@ -5,7 +5,7 @@ declare module "tty" { class ReadStream extends net.Socket { constructor(fd: number, options?: net.SocketConstructorOpts); isRaw: boolean; - setRawMode(mode: boolean): void; + setRawMode(mode: boolean): this; isTTY: boolean; } /**