From 4413fb75c4b802e6020fe49599b851dec7abf7cb Mon Sep 17 00:00:00 2001
From: Borys Kupar <borys.kupar@ottonova.de>
Date: Mon, 22 Jul 2019 20:06:14 +0200
Subject: [PATCH] [bull] Fixed queue process function definition (#36958)

* [bull] Fixed queue process function definition

* Revert version bump
---
 types/bull/bull-tests.tsx |  3 +++
 types/bull/index.d.ts     | 25 +++++++++++++------------
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/types/bull/bull-tests.tsx b/types/bull/bull-tests.tsx
index 58468fe900..22cd0dc638 100644
--- a/types/bull/bull-tests.tsx
+++ b/types/bull/bull-tests.tsx
@@ -51,6 +51,9 @@ videoQueue.process((job, done) => {
 
     // If the job throws an unhandled exception it is also handled correctly
     throw new Error('some unexpected error');
+}).catch(error => {
+    // Catch the general error, like redis connection
+    console.log(error);
 });
 
 audioQueue.process((job, done) => {
diff --git a/types/bull/index.d.ts b/types/bull/index.d.ts
index 95dd4790e3..0221a62adc 100644
--- a/types/bull/index.d.ts
+++ b/types/bull/index.d.ts
@@ -15,6 +15,7 @@
 //                 Christian D. <https://github.com/pc-jedi>
 //                 Silas Rech <https://github.com/lenovouser>
 //                 DoYoung Ha <https://github.com/hados99>
+//                 Borys Kupar <https://github.com/borys-kupar>
 // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
 // TypeScript Version: 2.8
 
@@ -475,9 +476,9 @@ declare namespace Bull {
      * If the promise is rejected, the error will be passed as a second argument to the "failed" event.
      * If it is resolved, its value will be the "completed" event's second argument.
      */
-    process(callback: ProcessCallbackFunction<T>): void;
-    process(callback: ProcessPromiseFunction<T>): void;
-    process(callback: string): void;
+    process(callback: ProcessCallbackFunction<T>): Promise<void>;
+    process(callback: ProcessPromiseFunction<T>): Promise<void>;
+    process(callback: string): Promise<void>;
 
     /**
      * Defines a processing function for the jobs placed into a given Queue.
@@ -498,9 +499,9 @@ declare namespace Bull {
      *
      * @param concurrency Bull will then call your handler in parallel respecting this maximum value.
      */
-    process(concurrency: number, callback: ProcessCallbackFunction<T>): void;
-    process(concurrency: number, callback: ProcessPromiseFunction<T>): void;
-    process(concurrency: number, callback: string): void;
+    process(concurrency: number, callback: ProcessCallbackFunction<T>): Promise<void>;
+    process(concurrency: number, callback: ProcessPromiseFunction<T>): Promise<void>;
+    process(concurrency: number, callback: string): Promise<void>;
 
     /**
      * Defines a processing function for the jobs placed into a given Queue.
@@ -521,9 +522,9 @@ declare namespace Bull {
      *
      * @param name Bull will only call the handler if the job name matches
      */
-    process(name: string, callback: ProcessCallbackFunction<T>): void;
-    process(name: string, callback: ProcessPromiseFunction<T>): void;
-    process(name: string, callback: string): void;
+    process(name: string, callback: ProcessCallbackFunction<T>): Promise<void>;
+    process(name: string, callback: ProcessPromiseFunction<T>): Promise<void>;
+    process(name: string, callback: string): Promise<void>;
 
     /**
      * Defines a processing function for the jobs placed into a given Queue.
@@ -545,9 +546,9 @@ declare namespace Bull {
      * @param name Bull will only call the handler if the job name matches
      * @param concurrency Bull will then call your handler in parallel respecting this maximum value.
      */
-    process(name: string, concurrency: number, callback: ProcessCallbackFunction<T>): void;
-    process(name: string, concurrency: number, callback: ProcessPromiseFunction<T>): void;
-    process(name: string, concurrency: number, callback: string): void;
+    process(name: string, concurrency: number, callback: ProcessCallbackFunction<T>): Promise<void>;
+    process(name: string, concurrency: number, callback: ProcessPromiseFunction<T>): Promise<void>;
+    process(name: string, concurrency: number, callback: string): Promise<void>;
 
     /* tslint:enable:unified-signatures */