From 44bc3b6c869d2ed59a7d359c74926024fcfe3938 Mon Sep 17 00:00:00 2001 From: Andre Z Sanchez Date: Fri, 4 May 2018 13:52:05 -0700 Subject: [PATCH] Fix Three.ParametricGeometry arguments (#25514) --- types/three/test/webgl/webgl_geometries.ts | 11 +++++++++++ types/three/three-core.d.ts | 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/types/three/test/webgl/webgl_geometries.ts b/types/three/test/webgl/webgl_geometries.ts index d09b865c6d..d239d1ca3c 100644 --- a/types/three/test/webgl/webgl_geometries.ts +++ b/types/three/test/webgl/webgl_geometries.ts @@ -96,6 +96,17 @@ object.position.set(0, 0, -200); scene.add(object); + + object = new THREE.Mesh( + new THREE.ParametricGeometry( + (u:number, v:number, dest:THREE.Vector3):void => { + dest.set(u, v, 0); + }, + 25, + 25 + ) + ); + object = new THREE.AxesHelper(50); object.position.set(200, 0, -200); scene.add(object); diff --git a/types/three/three-core.d.ts b/types/three/three-core.d.ts index f97768d34f..f32f975fb1 100644 --- a/types/three/three-core.d.ts +++ b/types/three/three-core.d.ts @@ -7096,10 +7096,10 @@ export class OctahedronGeometry extends PolyhedronGeometry { } export class ParametricGeometry extends Geometry { - constructor(func: (u: number, v: number) => Vector3, slices: number, stacks: number); + constructor(func: (u: number, v: number, dest:Vector3) => void, slices: number, stacks: number); parameters: { - func: (u: number, v: number) => Vector3; + func: (u: number, v: number, dest:Vector3) => void; slices: number; stacks: number; };