From 6a5051852ba4d81f3456717d0df9e415d9fb9aa0 Mon Sep 17 00:00:00 2001 From: devjedi Date: Tue, 18 Dec 2018 12:09:20 +0100 Subject: [PATCH 1/4] react-json-tree: Updated the definition of the valueRenderer method The valueRenderer is actually provided with more attributes then just a raw value. Also the first attribute is not the rawValue but the already pre-parsed displayValue (e.g. with quotes around a string). --- types/react-json-tree/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-json-tree/index.d.ts b/types/react-json-tree/index.d.ts index f32cc61521..5b1585f9fa 100644 --- a/types/react-json-tree/index.d.ts +++ b/types/react-json-tree/index.d.ts @@ -19,7 +19,7 @@ export interface JSONTreeProps extends Props { shouldExpandNode?: (keyPath: (string | number)[], data: [any] | {}, level: number) => boolean; getItemString?: (type: string, data: [any] | {}, itemType: string, itemString: string) => JSX.Element; labelRenderer?: (raw: [string, string]) => JSX.Element; - valueRenderer?: (raw: string) => JSX.Element; + valueRenderer?: (displayValue: string, rawValue: string, key: string, parentKey: string) => JSX.Element; postprocessValue?: (raw: string) => JSX.Element; isCustomNode?: () => boolean; collectionLimit?: number; From 9f0ed5d9a7f615ec5cc10a495cd2de284210ac91 Mon Sep 17 00:00:00 2001 From: devjedi Date: Tue, 25 Dec 2018 12:13:08 +0100 Subject: [PATCH 2/4] Improved the valueRenderer signature --- types/react-json-tree/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-json-tree/index.d.ts b/types/react-json-tree/index.d.ts index 5b1585f9fa..f3211551cb 100644 --- a/types/react-json-tree/index.d.ts +++ b/types/react-json-tree/index.d.ts @@ -19,7 +19,7 @@ export interface JSONTreeProps extends Props { shouldExpandNode?: (keyPath: (string | number)[], data: [any] | {}, level: number) => boolean; getItemString?: (type: string, data: [any] | {}, itemType: string, itemString: string) => JSX.Element; labelRenderer?: (raw: [string, string]) => JSX.Element; - valueRenderer?: (displayValue: string, rawValue: string, key: string, parentKey: string) => JSX.Element; + valueRenderer?: (displayValue: string|number, rawValue?: any, ...path?) => JSX.Element; postprocessValue?: (raw: string) => JSX.Element; isCustomNode?: () => boolean; collectionLimit?: number; From b787ad15bd5393c2836a5286e8365e0f53de716a Mon Sep 17 00:00:00 2001 From: devjedi Date: Tue, 25 Dec 2018 12:26:08 +0100 Subject: [PATCH 3/4] Improved the valueRendererer Signature. --- types/react-json-tree/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-json-tree/index.d.ts b/types/react-json-tree/index.d.ts index f3211551cb..6525d88b55 100644 --- a/types/react-json-tree/index.d.ts +++ b/types/react-json-tree/index.d.ts @@ -19,7 +19,7 @@ export interface JSONTreeProps extends Props { shouldExpandNode?: (keyPath: (string | number)[], data: [any] | {}, level: number) => boolean; getItemString?: (type: string, data: [any] | {}, itemType: string, itemString: string) => JSX.Element; labelRenderer?: (raw: [string, string]) => JSX.Element; - valueRenderer?: (displayValue: string|number, rawValue?: any, ...path?) => JSX.Element; + valueRenderer?: (displayValue: string|number, rawValue?: string|number|boolean, ...keyPath) => JSX.Element; postprocessValue?: (raw: string) => JSX.Element; isCustomNode?: () => boolean; collectionLimit?: number; From 5c1bba060ff8842b0dda071dbb1f85f771a6460f Mon Sep 17 00:00:00 2001 From: devjedi Date: Tue, 25 Dec 2018 14:00:27 +0100 Subject: [PATCH 4/4] Fixed the valueRenderer syntax. --- types/react-json-tree/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-json-tree/index.d.ts b/types/react-json-tree/index.d.ts index 6525d88b55..d0ab7cab62 100644 --- a/types/react-json-tree/index.d.ts +++ b/types/react-json-tree/index.d.ts @@ -19,7 +19,7 @@ export interface JSONTreeProps extends Props { shouldExpandNode?: (keyPath: (string | number)[], data: [any] | {}, level: number) => boolean; getItemString?: (type: string, data: [any] | {}, itemType: string, itemString: string) => JSX.Element; labelRenderer?: (raw: [string, string]) => JSX.Element; - valueRenderer?: (displayValue: string|number, rawValue?: string|number|boolean, ...keyPath) => JSX.Element; + valueRenderer?: (displayValue: string|number, rawValue?: string|number|boolean|null, ...keyPath: (string|number)[]) => JSX.Element; postprocessValue?: (raw: string) => JSX.Element; isCustomNode?: () => boolean; collectionLimit?: number;