From 4787f17ca6938ced9c1d088fcac5a3f83b512d1c Mon Sep 17 00:00:00 2001 From: Ondrej Sevcik Date: Tue, 17 Oct 2017 17:53:05 +0200 Subject: [PATCH] Puppeteer: Change page.url() return type (#20598) * Change page.url() return type According to docs frame.url() as well as page.url() returns just string, not promise. source: https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#frameurl * Increment version number * Increment version number to the latest puppeteer available * Set typings version to the latest released version --- types/puppeteer/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/puppeteer/index.d.ts b/types/puppeteer/index.d.ts index f9c5741805..708ad90d95 100644 --- a/types/puppeteer/index.d.ts +++ b/types/puppeteer/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for puppeteer 0.10 +// Type definitions for puppeteer 0.12 // Project: https://github.com/GoogleChrome/puppeteer#readme // Definitions by: Marvin Hagemeister // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -240,7 +240,7 @@ export interface FrameBase { ...args: Array ): Promise; title(): Promise; - url(): Promise; + url(): string; waitFor( // fn can be an abritary function // tslint:disable-next-line ban-types