From d7aceb16cd5c8a3cf0115257858d2309372bb4a4 Mon Sep 17 00:00:00 2001 From: Frank Brullo Date: Thu, 4 Apr 2019 14:20:51 -0400 Subject: [PATCH 1/3] Added the optional parameter to the save function. --- types/jspdf/index.d.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/types/jspdf/index.d.ts b/types/jspdf/index.d.ts index 63789a7093..d56e7073ec 100644 --- a/types/jspdf/index.d.ts +++ b/types/jspdf/index.d.ts @@ -1,8 +1,9 @@ -// Type definitions for jsPDF 1.2 +// Type definitions for jsPDF 1.3 // Project: https://github.com/MrRio/jsPDF // Definitions by: Amber Schühmacher // Kevin Gonnord // Jackie Weng +// Frank Brullo // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare module 'jspdf' { @@ -76,7 +77,7 @@ declare module 'jspdf' { setLineCap(style:string|number):jsPDF; setLineJoin(style:string|number):jsPDF; output(type?:string, options?:any):any; - save(filename:string):jsPDF; + save(filename:string, options?: {returnPromise: boolean}): Promise; /** * jsPDF plugins below: From 0dab0a5fdd1c720fce617d2695908fc850034936 Mon Sep 17 00:00:00 2001 From: Jackie Weng Date: Thu, 4 Apr 2019 22:55:53 -0400 Subject: [PATCH 2/3] Update types/jspdf/index.d.ts Co-Authored-By: FrankBrullo <43351788+FrankBrullo@users.noreply.github.com> --- types/jspdf/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/jspdf/index.d.ts b/types/jspdf/index.d.ts index d56e7073ec..e26d8f13c1 100644 --- a/types/jspdf/index.d.ts +++ b/types/jspdf/index.d.ts @@ -77,7 +77,8 @@ declare module 'jspdf' { setLineCap(style:string|number):jsPDF; setLineJoin(style:string|number):jsPDF; output(type?:string, options?:any):any; - save(filename:string, options?: {returnPromise: boolean}): Promise; + save(filename:string): void; + save(filename:string, options: {returnPromise: boolean}): Promise; /** * jsPDF plugins below: From 9892418987c3e080df1b6d5f21acbc810effdbc0 Mon Sep 17 00:00:00 2001 From: Frank Brullo Date: Thu, 4 Apr 2019 23:25:31 -0400 Subject: [PATCH 3/3] fixed wrong measure text return value type. --- types/jspdf/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/jspdf/index.d.ts b/types/jspdf/index.d.ts index e26d8f13c1..c3507fc5e5 100644 --- a/types/jspdf/index.d.ts +++ b/types/jspdf/index.d.ts @@ -186,7 +186,7 @@ declare module 'jspdf' { stroke():void; fill():void; translate(x:number, y:number):void; - measureText(text:string):number; + measureText(text:string):{ width: number }; }; // jsPDF plugin: fromHTML