From 4ae5b31d1494038dfc8a93aba53b9e4f9ad393c0 Mon Sep 17 00:00:00 2001 From: Andy Date: Mon, 17 Apr 2017 09:35:17 -0700 Subject: [PATCH] electron-builder: Provides its own types (#15644) --- notNeededPackages.json | 6 ++ .../electron-builder-tests.ts | 54 ----------- types/electron-builder/index.d.ts | 90 ------------------- types/electron-builder/tsconfig.json | 22 ----- 4 files changed, 6 insertions(+), 166 deletions(-) delete mode 100644 types/electron-builder/electron-builder-tests.ts delete mode 100644 types/electron-builder/index.d.ts delete mode 100644 types/electron-builder/tsconfig.json diff --git a/notNeededPackages.json b/notNeededPackages.json index 8e4292e091..edf3476789 100644 --- a/notNeededPackages.json +++ b/notNeededPackages.json @@ -132,6 +132,12 @@ "sourceRepoURL": "https://www.npmjs.com/package/fast-simplex-noise", "asOfVersion": "3.0.0" }, + { + "libraryName": "electron-builder", + "typingsPackageName": "electron-builder", + "sourceRepoURL": "https://github.com/loopline-systems/electron-builder", + "asOfVersion": "2.8.0" + }, { "libraryName": "FineUploader", "typingsPackageName": "fine-uploader", diff --git a/types/electron-builder/electron-builder-tests.ts b/types/electron-builder/electron-builder-tests.ts deleted file mode 100644 index 8ae7479882..0000000000 --- a/types/electron-builder/electron-builder-tests.ts +++ /dev/null @@ -1,54 +0,0 @@ - - -import * as factory from "electron-builder"; -const builder = factory.init(); - -function callback(err: Error) { - const msg = err.message; -} - -builder.build({ - appPath: ".", - out: "out", - platform: "win", - config: { - osx: { - title: "myapplication", - icon: "icon.icns", - "icon-size": 80, - background: "installer.png", - contents: [ - { x: 438, y: 344, type: "link", path: "/Applications" }, - { x: 192, y: 344, type: "file" }, - ] - }, - win: { - title: "myapplication", - icon: "icon.ico" - } - } -}, callback); - -const bldr = require("electron-builder").init(); - -bldr.build({ - appPath: ".", - out: "out", - platform: "osx", - config: { - osx: { - title: "myapplication", - icon: "icon.icns", - "icon-size": 80, - background: "installer.png", - contents: [ - { x: 438, y: 344, type: "link", path: "/Applications" }, - { x: 192, y: 344, type: "file" }, - ] - }, - win: { - title: "myapplication", - icon: "icon.ico" - } - } -}, callback); diff --git a/types/electron-builder/index.d.ts b/types/electron-builder/index.d.ts deleted file mode 100644 index 3daa291b55..0000000000 --- a/types/electron-builder/index.d.ts +++ /dev/null @@ -1,90 +0,0 @@ -// Type definitions for electron-builder v2.0.2 -// Project: https://github.com/loopline-systems/electron-builder -// Definitions by: Maxime LUCE -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - -/// - -declare namespace ElectronBuilder { - - /** Electron-builder Options. */ - export interface Options { - /** Source application path. */ - appPath: string; - - /** Platforms to build. Allowed values: win, osx, all. */ - platform: string; - - /** Path or Object. Configuration for build. */ - config: string | Config; - - /** The output directory. */ - out?: string; - - } - - /** Build configuration by platforms. */ - export interface Config { - /** Configurations for Mac OS X. */ - osx: { - /** Installer title. */ - title: string; - /** Installer background. */ - background: string; - /** Installer icon. */ - icon: string; - /** Installer icon size. */ - "icon-size": number; - /** Installer custom contents. */ - contents: [OsxContents, OsxContents] - }; - - /** Configurations for Windows. */ - win: { - /** Installer title. */ - title: string; - /** Installer icon. */ - icon: string; - }; - } - - /** OSX Installer custom contents. */ - export interface OsxContents { - /** Horizontal position on installer screen (in pixels). */ - x: number; - /** Vertical position on installer screen (in pixels). */ - y: number; - /** Content type. Allowed values are "file", "link". */ - type: string; - /** Link only. Customize link destination path. */ - path?: string; - } - - /** Electron-builder done callback. */ - export interface Callback { - /** - * Callback wich is called when electron-builder is done. - * @param err - Contains errors if any. - */ - (err: Error): void - } - - /** Prototype for electron-builder. */ - export interface Builder { - /** - * Build the installer for given platform. - * - * @param opts - Options to configure installer. - * @param callback - Callback which is called when building is done or an error occured. - */ - build(opts: Options, callback: Callback): void; - } -} - -declare module "electron-builder" { - export function init(): ElectronBuilder.Builder; -} - -interface NodeRequireFunction { - (id: "electron-builder"): { init(): ElectronBuilder.Builder }; -} diff --git a/types/electron-builder/tsconfig.json b/types/electron-builder/tsconfig.json deleted file mode 100644 index c1cf1c01eb..0000000000 --- a/types/electron-builder/tsconfig.json +++ /dev/null @@ -1,22 +0,0 @@ -{ - "compilerOptions": { - "module": "commonjs", - "lib": [ - "es6" - ], - "noImplicitAny": true, - "noImplicitThis": true, - "strictNullChecks": false, - "baseUrl": "../", - "typeRoots": [ - "../" - ], - "types": [], - "noEmit": true, - "forceConsistentCasingInFileNames": true - }, - "files": [ - "index.d.ts", - "electron-builder-tests.ts" - ] -} \ No newline at end of file