From 4c25d57e2f63b31991a2832b990bb0feddf8bce7 Mon Sep 17 00:00:00 2001 From: "FUJI Goro (gfx)" Date: Mon, 14 May 2018 11:52:54 +0900 Subject: [PATCH] the original classname() accepts boolean, as well as falsy values --- types/classnames/classnames-tests.ts | 3 +++ types/classnames/index.d.ts | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/types/classnames/classnames-tests.ts b/types/classnames/classnames-tests.ts index b2b8c9eba4..55b801eb40 100644 --- a/types/classnames/classnames-tests.ts +++ b/types/classnames/classnames-tests.ts @@ -38,3 +38,6 @@ const className = cx('foo', ['bar'], { baz: true }); // => "abc def xyz" // falsey values are just ignored cx(null, 'bar', undefined, 0, 1, { baz: null }, ''); // => 'bar 1' + +// true is just ignored +cx(true || "foo"); diff --git a/types/classnames/index.d.ts b/types/classnames/index.d.ts index ce2abb5ee3..40e3ce835c 100644 --- a/types/classnames/index.d.ts +++ b/types/classnames/index.d.ts @@ -9,7 +9,7 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 -type ClassValue = string | number | ClassDictionary | ClassArray | undefined | null | false; +type ClassValue = string | number | ClassDictionary | ClassArray | undefined | null | boolean; interface ClassDictionary { [id: string]: boolean | undefined | null;