From 4eee6080afff3147261a431727b7fc9b9bb735cf Mon Sep 17 00:00:00 2001 From: Alexander T Date: Tue, 29 Oct 2019 06:15:05 +0200 Subject: [PATCH] delegated-events: Provides its own types (#39628) --- notNeededPackages.json | 6 ++++ .../delegated-events-tests.ts | 29 ------------------- types/delegated-events/index.d.ts | 27 ----------------- types/delegated-events/tsconfig.json | 24 --------------- types/delegated-events/tslint.json | 1 - 5 files changed, 6 insertions(+), 81 deletions(-) delete mode 100644 types/delegated-events/delegated-events-tests.ts delete mode 100644 types/delegated-events/index.d.ts delete mode 100644 types/delegated-events/tsconfig.json delete mode 100644 types/delegated-events/tslint.json diff --git a/notNeededPackages.json b/notNeededPackages.json index b70114660d..e2b8aa4692 100644 --- a/notNeededPackages.json +++ b/notNeededPackages.json @@ -756,6 +756,12 @@ "sourceRepoURL": "https://github.com/sindresorhus/delay", "asOfVersion": "3.1.0" }, + { + "libraryName": "delegated-events", + "typingsPackageName": "delegated-events", + "sourceRepoURL": "https://github.com/dgraham/delegated-events#readme", + "asOfVersion": "1.1.0" + }, { "libraryName": "detect-browser", "typingsPackageName": "detect-browser", diff --git a/types/delegated-events/delegated-events-tests.ts b/types/delegated-events/delegated-events-tests.ts deleted file mode 100644 index da565686ce..0000000000 --- a/types/delegated-events/delegated-events-tests.ts +++ /dev/null @@ -1,29 +0,0 @@ -// Tests are re-used based on `delegated-events`'s flow tests. -// https://github.com/dgraham/delegated-events/blob/master/test/test-flow.js - -import { on, off, fire } from "delegated-events"; - -function onButtonClick(event: Event) { - event.target; -} - -on("click"); // $ExpectError -on("click", ".js-button"); // $ExpectError -on("click", ".js-button", onButtonClick); // $ExpectType void - -off("click"); // $ExpectError -off("click", ".js-button"); // $ExpectError -off("click", ".js-button", onButtonClick); // $ExpectType void - -// $ExpectType void -on("robot:singularity", ".js-robot-image", (event: Event) => { - event.target; -}); - -const image = document.querySelector(".js-button"); - -if (image) { - fire(image); // $ExpectError - fire(image, "robot:singularity"); // $ExpectType boolean - fire(image, "robot:singularity", { name: "Hubot" }); // $ExpectType boolean -} diff --git a/types/delegated-events/index.d.ts b/types/delegated-events/index.d.ts deleted file mode 100644 index 2fe2a35e41..0000000000 --- a/types/delegated-events/index.d.ts +++ /dev/null @@ -1,27 +0,0 @@ -// Type definitions for delegated-events 1.0 -// Project: https://github.com/dgraham/delegated-events#readme -// Definitions by: Christopher Parsons -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - -// Definitions based on the projects' flow definitions. -// https://github.com/dgraham/delegated-events/blob/master/delegated-events.js.flow - -export interface EventListenerOptions { - capture?: boolean; -} - -export function on( - name: string, - selector: string, - handler: EventListenerOrEventListenerObject, - options?: EventListenerOptions -): void; - -export function off( - name: string, - selector: string, - handler: EventListenerOrEventListenerObject, - options?: EventListenerOptions -): void; - -export function fire(target: EventTarget, name: string, detail?: any): boolean; diff --git a/types/delegated-events/tsconfig.json b/types/delegated-events/tsconfig.json deleted file mode 100644 index c5e2b6d93e..0000000000 --- a/types/delegated-events/tsconfig.json +++ /dev/null @@ -1,24 +0,0 @@ -{ - "compilerOptions": { - "module": "commonjs", - "lib": [ - "es6", - "dom" - ], - "noImplicitAny": true, - "noImplicitThis": true, - "strictNullChecks": true, - "strictFunctionTypes": true, - "baseUrl": "../", - "typeRoots": [ - "../" - ], - "types": [], - "noEmit": true, - "forceConsistentCasingInFileNames": true - }, - "files": [ - "index.d.ts", - "delegated-events-tests.ts" - ] -} diff --git a/types/delegated-events/tslint.json b/types/delegated-events/tslint.json deleted file mode 100644 index 3db14f85ea..0000000000 --- a/types/delegated-events/tslint.json +++ /dev/null @@ -1 +0,0 @@ -{ "extends": "dtslint/dt.json" }