From 88e0310558e7c1a73f84b7b349a0434bc43b3024 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 09:25:10 +0100 Subject: [PATCH 01/10] added type declarations for youtube-player --- .../youtube-player/dist/FunctionStateMap.d.ts | 31 ++++ types/youtube-player/dist/YouTubePlayer.d.ts | 12 ++ .../dist/constants/PlayerStates.d.ts | 10 ++ types/youtube-player/dist/eventNames.d.ts | 20 +++ types/youtube-player/dist/functionNames.d.ts | 46 ++++++ types/youtube-player/dist/index.d.ts | 9 ++ .../dist/loadYouTubeIframeApi.d.ts | 4 + types/youtube-player/dist/types.d.ts | 140 ++++++++++++++++++ types/youtube-player/index.d.ts | 9 ++ types/youtube-player/package.json | 5 + types/youtube-player/tsconfig.json | 25 ++++ types/youtube-player/tslint.json | 3 + 12 files changed, 314 insertions(+) create mode 100644 types/youtube-player/dist/FunctionStateMap.d.ts create mode 100644 types/youtube-player/dist/YouTubePlayer.d.ts create mode 100644 types/youtube-player/dist/constants/PlayerStates.d.ts create mode 100644 types/youtube-player/dist/eventNames.d.ts create mode 100644 types/youtube-player/dist/functionNames.d.ts create mode 100644 types/youtube-player/dist/index.d.ts create mode 100644 types/youtube-player/dist/loadYouTubeIframeApi.d.ts create mode 100644 types/youtube-player/dist/types.d.ts create mode 100644 types/youtube-player/index.d.ts create mode 100644 types/youtube-player/package.json create mode 100644 types/youtube-player/tsconfig.json create mode 100644 types/youtube-player/tslint.json diff --git a/types/youtube-player/dist/FunctionStateMap.d.ts b/types/youtube-player/dist/FunctionStateMap.d.ts new file mode 100644 index 0000000000..b45a35d145 --- /dev/null +++ b/types/youtube-player/dist/FunctionStateMap.d.ts @@ -0,0 +1,31 @@ +import PlayerStates from './constants/PlayerStates.js'; + +declare const FUNCTION_STATE_MAP: { + pauseVideo: { + acceptableStates: [ + PlayerStates.ENDED, + PlayerStates.PAUSED + ], + stateChangeRequired: false, + }, + playVideo: { + acceptableStates: [ + PlayerStates.ENDED, + PlayerStates.PLAYING + ], + stateChangeRequired: false, + }, + seekTo: { + acceptableStates: [ + PlayerStates.ENDED, + PlayerStates.PLAYING, + PlayerStates.PAUSED + ], + stateChangeRequired: true, + + // TRICKY: `seekTo` may not cause a state change if no buffering is required. + timeout: 3000, + }, +}; + +export default FUNCTION_STATE_MAP; diff --git a/types/youtube-player/dist/YouTubePlayer.d.ts b/types/youtube-player/dist/YouTubePlayer.d.ts new file mode 100644 index 0000000000..7716ca739c --- /dev/null +++ b/types/youtube-player/dist/YouTubePlayer.d.ts @@ -0,0 +1,12 @@ +import { EmitterType, YouTubePlayer } from './types'; + +export interface EventHandlerMapType { + [key: string]: (event: object) => void; +} + +declare const YouTubePlayerHelpers: { + proxyEvents(emitter: EmitterType): EventHandlerMapType, + promisifyPlayer(playerAPIReady: Promise, strictState?: boolean): YouTubePlayer, +}; + +export default YouTubePlayerHelpers; diff --git a/types/youtube-player/dist/constants/PlayerStates.d.ts b/types/youtube-player/dist/constants/PlayerStates.d.ts new file mode 100644 index 0000000000..a5beac4fa7 --- /dev/null +++ b/types/youtube-player/dist/constants/PlayerStates.d.ts @@ -0,0 +1,10 @@ +declare enum PlayerStates { + BUFFERING = 3, + ENDED = 0, + PAUSED = 2, + PLAYING = 1, + UNSTARTED = -1, + VIDEO_CUED = 5, +} + +export default PlayerStates; diff --git a/types/youtube-player/dist/eventNames.d.ts b/types/youtube-player/dist/eventNames.d.ts new file mode 100644 index 0000000000..a86d3b5625 --- /dev/null +++ b/types/youtube-player/dist/eventNames.d.ts @@ -0,0 +1,20 @@ +declare const EVENT_NAMES: [ + 'ready', + 'stateChange', + 'playbackQualityChange', + 'playbackRateChange', + 'error', + 'apiChange', + 'volumeChange' +]; + +export default EVENT_NAMES; + +export type EventType = + 'ready' | + 'stateChange' | + 'playbackQualityChange' | + 'playbackRateChange' | + 'error' | + 'apiChange' | + 'volumeChange'; diff --git a/types/youtube-player/dist/functionNames.d.ts b/types/youtube-player/dist/functionNames.d.ts new file mode 100644 index 0000000000..1e317d7391 --- /dev/null +++ b/types/youtube-player/dist/functionNames.d.ts @@ -0,0 +1,46 @@ +declare const FUNCTION_NAMES: [ + 'cueVideoById', + 'loadVideoById', + 'cueVideoByUrl', + 'loadVideoByUrl', + 'playVideo', + 'pauseVideo', + 'stopVideo', + 'getVideoLoadedFraction', + 'cuePlaylist', + 'loadPlaylist', + 'nextVideo', + 'previousVideo', + 'playVideoAt', + 'setShuffle', + 'setLoop', + 'getPlaylist', + 'getPlaylistIndex', + 'setOption', + 'mute', + 'unMute', + 'isMuted', + 'setVolume', + 'getVolume', + 'seekTo', + 'getPlayerState', + 'getPlaybackRate', + 'setPlaybackRate', + 'getAvailablePlaybackRates', + 'getPlaybackQuality', + 'setPlaybackQuality', + 'getAvailableQualityLevels', + 'getCurrentTime', + 'getDuration', + 'removeEventListener', + 'getVideoUrl', + 'getVideoEmbedCode', + 'getOptions', + 'getOption', + 'addEventListener', + 'destroy', + 'setSize', + 'getIframe' +]; + +export default FUNCTION_NAMES; diff --git a/types/youtube-player/dist/index.d.ts b/types/youtube-player/dist/index.d.ts new file mode 100644 index 0000000000..09f07ff9c8 --- /dev/null +++ b/types/youtube-player/dist/index.d.ts @@ -0,0 +1,9 @@ +import { Options, YouTubePlayer } from './types'; + +declare function PlayerFactory( + maybeElementId: YouTubePlayer | HTMLElement | string, + options?: Options, + strictState?: boolean, +): YouTubePlayer; + +export default PlayerFactory; diff --git a/types/youtube-player/dist/loadYouTubeIframeApi.d.ts b/types/youtube-player/dist/loadYouTubeIframeApi.d.ts new file mode 100644 index 0000000000..7faddafbb9 --- /dev/null +++ b/types/youtube-player/dist/loadYouTubeIframeApi.d.ts @@ -0,0 +1,4 @@ +import { EmitterType, IframeApiType } from './types'; + +declare function Loader(emitter: EmitterType): Promise; +export default Loader; diff --git a/types/youtube-player/dist/types.d.ts b/types/youtube-player/dist/types.d.ts new file mode 100644 index 0000000000..340c7b7854 --- /dev/null +++ b/types/youtube-player/dist/types.d.ts @@ -0,0 +1,140 @@ +import PlayerState from './constants/PlayerStates'; +import { EventType } from './eventNames'; + +export interface EmitterType { + trigger: (eventName: string, event: object) => void; +} + +export interface Options { + width?: number; + height?: number; + videoId?: string; + playerVars?: { + autoplay?: 0 | 1, + cc_lang_pref?: string, + cc_load_policy?: 1, + color?: 'red' | 'white', + controls?: 0 | 1, + disablekb?: 0 | 1, + enablejsapi?: 0 | 1, + end?: number, + fs?: 0 | 1, + hl?: string, + iv_load_policy?: 1 | 3, + list?: string, + listType?: 'playlist' | 'search' | 'user_uploads', + loop?: 0 | 1, + modestbranding?: 1, + origin?: string, + playlist: string, + playsinline?: 0 | 1, + rel?: 0 | 1, + start?: number, + widget_referrer?: string, + }; + events?: { + [eventType in EventType]: (event: CustomEvent) => void + }; +} + +export interface IframeApiType { + Player: {new(elementId: string, options: Options): YouTubePlayer}; +} + +/** + * @see https://developers.google.com/youtube/iframe_api_reference + */ +export interface YouTubePlayer { + addEventListener(event: string, listener: (event: CustomEvent) => void): void; + destroy(): void; + getAvailablePlaybackRates(): ReadonlyArray; + getAvailableQualityLevels(): ReadonlyArray; + getCurrentTime(): number; + getDuration(): number; + getIframe(): HTMLIFrameElement; + getOption(module: string, option: string): any; + getOptions(): string[]; + getOptions(module: string): object; + setOption(module: string, option: string, value: any): void; + setOptions(): void; + cuePlaylist( + playlist: string | ReadonlyArray, + index?: number, + startSeconds?: number, + suggestedQuality?: string, + ): void; + cuePlaylist(playlist: { + listType: string, + list?: string, + index?: number, + startSeconds?: number, + suggestedQuality?: string, + }): void; + loadPlaylist( + playlist: string | ReadonlyArray, + index?: number, + startSeconds?: number, + suggestedQuality?: string, + ): void; + loadPlaylist(playlist: { + listType: string, + list?: string, + index?: number, + startSeconds?: number, + suggestedQuality?: string, + }): void; + getPlaylist(): ReadonlyArray; + getPlaylistIndex(): number; + getPlaybackQuality(): string; + getPlaybackRate(): number; + getPlayerState(): PlayerState; + getVideoEmbedCode(): string; + getVideoLoadedFraction(): number; + getVideoUrl(): string; + getVolume(): number; + cueVideoById(videoId: string, startSeconds?: number, suggestedQuality?: string): void; + cueVideoById(video: { + videoId: string, + startSeconds?: number, + endSeconds?: number, + suggestedQuality?: string, + }): void; + cueVideoByUrl(mediaContentUrl: string, startSeconds?: number, suggestedQuality?: string): void; + cueVideoByUrl(video: { + mediaContentUrl: string, + startSeconds?: number, + endSeconds?: number, + suggestedQuality?: string, + }): void; + loadVideoByUrl(mediaContentUrl: string, startSeconds?: number, suggestedQuality?: string): void; + loadVideoByUrl(video: { + mediaContentUrl: string, + startSeconds?: number, + endSeconds?: number, + suggestedQuality?: string, + }): void; + loadVideoById(videoId: string, startSeconds?: number, suggestedQuality?: string): void; + loadVideoById(video: { + videoId: string, + startSeconds?: number, + endSeconds?: number, + suggestedQuality?: string, + }): void; + isMuted(): boolean; + mute(): void; + nextVideo(): void; + pauseVideo(): void; + playVideo(): void; + playVideoAt(index: number): void; + previousVideo(): void; + removeEventListener(event: string, listener: (event: CustomEvent) => void): void; + seekTo(seconds: number, allowSeekAhead: boolean): void; + setLoop(loopPlaylists: boolean): void; + setPlaybackQuality(suggestedQuality: string): void; + setPlaybackRate(suggestedRate: number): void; + setShuffle(shufflePlaylist: boolean): void; + setSize(width: number, height: number): object; + setVolume(volume: number): void; + stopVideo(): void; + unMute(): void; +} diff --git a/types/youtube-player/index.d.ts b/types/youtube-player/index.d.ts new file mode 100644 index 0000000000..1cdab56427 --- /dev/null +++ b/types/youtube-player/index.d.ts @@ -0,0 +1,9 @@ +// Type definitions for youtube-player 5.5 +// Project: https://github.com/gajus/youtube-player +// Definitions by: Martin Jurča +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 3.0 + +import PlayerFactory from './dist/index'; + +export default PlayerFactory; diff --git a/types/youtube-player/package.json b/types/youtube-player/package.json new file mode 100644 index 0000000000..d0224c9efb --- /dev/null +++ b/types/youtube-player/package.json @@ -0,0 +1,5 @@ +{ + "private": true, + "dependencies": { + } +} diff --git a/types/youtube-player/tsconfig.json b/types/youtube-player/tsconfig.json new file mode 100644 index 0000000000..b447d9cac9 --- /dev/null +++ b/types/youtube-player/tsconfig.json @@ -0,0 +1,25 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6", + "dom" + ], + "jsx": "react", + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "strictFunctionTypes": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true, + "esModuleInterop": true + }, + "files": [ + "index.d.ts" + ] +} diff --git a/types/youtube-player/tslint.json b/types/youtube-player/tslint.json new file mode 100644 index 0000000000..f93cf8562a --- /dev/null +++ b/types/youtube-player/tslint.json @@ -0,0 +1,3 @@ +{ + "extends": "dtslint/dt.json" +} From d7c9e8cfbf149039f549b9552a379f499f787655 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 09:26:55 +0100 Subject: [PATCH 02/10] fixed file list for youtube-player --- types/youtube-player/tsconfig.json | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/types/youtube-player/tsconfig.json b/types/youtube-player/tsconfig.json index b447d9cac9..0abbd24356 100644 --- a/types/youtube-player/tsconfig.json +++ b/types/youtube-player/tsconfig.json @@ -20,6 +20,14 @@ "esModuleInterop": true }, "files": [ - "index.d.ts" + "index.d.ts", + "dist/constants/PlayerStates.d.ts", + "dist/eventNames.d.ts", + "dist/functionNames.d.ts", + "dist/FunctionStateMap.d.ts", + "dist/index.d.ts", + "dist/loadYouTubeIframeApi.d.ts", + "dist/types.d.ts", + "dist/YouTubePlayer.d.ts" ] } From 84eb0b5fad4d8498df4e7d77bbe2a92bfd05a134 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 09:28:44 +0100 Subject: [PATCH 03/10] fixed import paths --- types/youtube-player/dist/FunctionStateMap.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/youtube-player/dist/FunctionStateMap.d.ts b/types/youtube-player/dist/FunctionStateMap.d.ts index b45a35d145..5ee7b07081 100644 --- a/types/youtube-player/dist/FunctionStateMap.d.ts +++ b/types/youtube-player/dist/FunctionStateMap.d.ts @@ -1,4 +1,4 @@ -import PlayerStates from './constants/PlayerStates.js'; +import PlayerStates from './constants/PlayerStates'; declare const FUNCTION_STATE_MAP: { pauseVideo: { From 1eceff4d693e1c0ff3d6feb9984be20742542f25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 10:34:08 +0100 Subject: [PATCH 04/10] added a simple test code --- types/youtube-player/tsconfig.json | 1 - types/youtube-player/youtube-player-tests.ts | 48 ++++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) create mode 100644 types/youtube-player/youtube-player-tests.ts diff --git a/types/youtube-player/tsconfig.json b/types/youtube-player/tsconfig.json index 0abbd24356..9718e040d9 100644 --- a/types/youtube-player/tsconfig.json +++ b/types/youtube-player/tsconfig.json @@ -5,7 +5,6 @@ "es6", "dom" ], - "jsx": "react", "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": true, diff --git a/types/youtube-player/youtube-player-tests.ts b/types/youtube-player/youtube-player-tests.ts new file mode 100644 index 0000000000..ae23bc84de --- /dev/null +++ b/types/youtube-player/youtube-player-tests.ts @@ -0,0 +1,48 @@ +import youTubePlayerFactory from 'youtube-player'; +import PlayerStates from 'youtube-player/dist/constants/PlayerStates'; +import { YouTubePlayer } from 'youtube-player/dist/types'; + +youTubePlayerFactory('foo'); +const player: YouTubePlayer = youTubePlayerFactory( + document.getElementById('bar'), + { + width: 640, + height: 300, + videoId: 'aaaaaaaaaa', + playerVars: { + autoplay: 1, + cc_lang_pref: 'en_US', + cc_load_policy: 1, + color: 'white', + controls: 1, + disablekb: 0, + enablejsapi: 1, + end: 60, + fs: 0, + hl: 'fooBar', + iv_load_policy: 3, + list: 'bbbbbbbbbb', + listType: 'search', + loop: 0, + modestbranding: 1, + origin: 'https://definitelytyped.org/', + playlist: 'cccccccccc', + playsinline: 0, + rel: 1, + start: 3, + widget_referrer: 'nothing', + }, + events: { + ready: (event: CustomEvent): void => {}, + stateChange: (event: CustomEvent): void => { + console.log(player.getPlayerState() === PlayerStates.PLAYING); + }, + playbackQualityChange: (event: CustomEvent): void => {}, + playbackRateChange: (event: CustomEvent): void => {}, + error: (event: CustomEvent): void => {}, + apiChange: (event: CustomEvent): void => {}, + volumeChange: (event: CustomEvent): void => {}, + }, + }, + true, +); From 0751c2cc2628088769a5a4f2054137a3c74e9007 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 10:42:11 +0100 Subject: [PATCH 05/10] added tests to the file list --- types/youtube-player/tsconfig.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/youtube-player/tsconfig.json b/types/youtube-player/tsconfig.json index 9718e040d9..a9e32d2b61 100644 --- a/types/youtube-player/tsconfig.json +++ b/types/youtube-player/tsconfig.json @@ -27,6 +27,7 @@ "dist/index.d.ts", "dist/loadYouTubeIframeApi.d.ts", "dist/types.d.ts", - "dist/YouTubePlayer.d.ts" + "dist/YouTubePlayer.d.ts", + "youtube-player-tests.ts" ] } From 84836f19357bfaac01749304c4cae0a1c2efe4c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 10:43:57 +0100 Subject: [PATCH 06/10] fixed null issue in tests --- types/youtube-player/youtube-player-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/youtube-player/youtube-player-tests.ts b/types/youtube-player/youtube-player-tests.ts index ae23bc84de..df622b36aa 100644 --- a/types/youtube-player/youtube-player-tests.ts +++ b/types/youtube-player/youtube-player-tests.ts @@ -4,7 +4,7 @@ import { YouTubePlayer } from 'youtube-player/dist/types'; youTubePlayerFactory('foo'); const player: YouTubePlayer = youTubePlayerFactory( - document.getElementById('bar'), + document.getElementById('bar')!, { width: 640, height: 300, From c21085db2a9d6b7f8e7e86fff4cace0f70c83664 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 10:55:21 +0100 Subject: [PATCH 07/10] extended the tests, added missing API --- types/youtube-player/dist/types.d.ts | 2 ++ types/youtube-player/youtube-player-tests.ts | 33 ++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/types/youtube-player/dist/types.d.ts b/types/youtube-player/dist/types.d.ts index 340c7b7854..fa64feda04 100644 --- a/types/youtube-player/dist/types.d.ts +++ b/types/youtube-player/dist/types.d.ts @@ -137,4 +137,6 @@ export interface YouTubePlayer { setVolume(volume: number): void; stopVideo(): void; unMute(): void; + on(eventType: 'stateChange', listener: (event: CustomEvent & {data: number}) => void): void; + on(eventType: EventType, listener: (event: CustomEvent) => void): void; } diff --git a/types/youtube-player/youtube-player-tests.ts b/types/youtube-player/youtube-player-tests.ts index df622b36aa..cb60168cea 100644 --- a/types/youtube-player/youtube-player-tests.ts +++ b/types/youtube-player/youtube-player-tests.ts @@ -46,3 +46,36 @@ const player: YouTubePlayer = youTubePlayerFactory( }, true, ); + +player.cueVideoById('xyzabc123'); +player.loadVideoById('doesNotExist'); +player.playVideo(); +player.pauseVideo(); +player.setSize(320, 200); +if (player.isMuted()) { + player.unMute(); +} else { + player.mute(); +} +player.setVolume(player.getVolume() / 2); + +player.on('stateChange', (event: CustomEvent & {data: number}) => { + switch (event.data) { + case PlayerStates.PLAYING: + console.log('playing'); + break; + case PlayerStates.PAUSED: + console.log('paused'); + break; + case PlayerStates.ENDED: + console.log('ended'); + break; + default: + break; + } +}); +player.on('error', (event: CustomEvent) => { + console.error('player error', event.detail); +}); + +player.destroy(); From 9dbc92e9e905cd9c5cc8baad450583a991565d30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 11:04:06 +0100 Subject: [PATCH 08/10] generated the meta-files using dts-gen --dt --- types/youtube-player/index.d.ts | 3 +-- types/youtube-player/package.json | 5 ----- types/youtube-player/tsconfig.json | 6 ++---- types/youtube-player/tslint.json | 4 +--- 4 files changed, 4 insertions(+), 14 deletions(-) delete mode 100644 types/youtube-player/package.json diff --git a/types/youtube-player/index.d.ts b/types/youtube-player/index.d.ts index 1cdab56427..ecf606bce9 100644 --- a/types/youtube-player/index.d.ts +++ b/types/youtube-player/index.d.ts @@ -1,8 +1,7 @@ // Type definitions for youtube-player 5.5 -// Project: https://github.com/gajus/youtube-player +// Project: https://github.com/gajus/youtube-player#readme // Definitions by: Martin Jurča // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// TypeScript Version: 3.0 import PlayerFactory from './dist/index'; diff --git a/types/youtube-player/package.json b/types/youtube-player/package.json deleted file mode 100644 index d0224c9efb..0000000000 --- a/types/youtube-player/package.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "private": true, - "dependencies": { - } -} diff --git a/types/youtube-player/tsconfig.json b/types/youtube-player/tsconfig.json index a9e32d2b61..a13a7ebc76 100644 --- a/types/youtube-player/tsconfig.json +++ b/types/youtube-player/tsconfig.json @@ -2,8 +2,7 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es6", - "dom" + "es6" ], "noImplicitAny": true, "noImplicitThis": true, @@ -15,8 +14,7 @@ ], "types": [], "noEmit": true, - "forceConsistentCasingInFileNames": true, - "esModuleInterop": true + "forceConsistentCasingInFileNames": true }, "files": [ "index.d.ts", diff --git a/types/youtube-player/tslint.json b/types/youtube-player/tslint.json index f93cf8562a..3db14f85ea 100644 --- a/types/youtube-player/tslint.json +++ b/types/youtube-player/tslint.json @@ -1,3 +1 @@ -{ - "extends": "dtslint/dt.json" -} +{ "extends": "dtslint/dt.json" } From 3b534be4d099d334b905d7be25dc27b4f7bab964 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 11:05:29 +0100 Subject: [PATCH 09/10] fixed configuration --- types/youtube-player/index.d.ts | 1 + types/youtube-player/tsconfig.json | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/types/youtube-player/index.d.ts b/types/youtube-player/index.d.ts index ecf606bce9..3e05adde80 100644 --- a/types/youtube-player/index.d.ts +++ b/types/youtube-player/index.d.ts @@ -2,6 +2,7 @@ // Project: https://github.com/gajus/youtube-player#readme // Definitions by: Martin Jurča // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 2.2 import PlayerFactory from './dist/index'; diff --git a/types/youtube-player/tsconfig.json b/types/youtube-player/tsconfig.json index a13a7ebc76..1abbcc804c 100644 --- a/types/youtube-player/tsconfig.json +++ b/types/youtube-player/tsconfig.json @@ -2,7 +2,8 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es6" + "es6", + "dom" ], "noImplicitAny": true, "noImplicitThis": true, From 5fa4537382146a0f14642a86f28d2c3ede51ba30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Jur=C4=8Da?= Date: Fri, 15 Feb 2019 11:06:32 +0100 Subject: [PATCH 10/10] updated typescript version requirement from 2.2 to 2.7 --- types/youtube-player/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/youtube-player/index.d.ts b/types/youtube-player/index.d.ts index 3e05adde80..f34f8e3505 100644 --- a/types/youtube-player/index.d.ts +++ b/types/youtube-player/index.d.ts @@ -2,7 +2,7 @@ // Project: https://github.com/gajus/youtube-player#readme // Definitions by: Martin Jurča // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// TypeScript Version: 2.2 +// TypeScript Version: 2.7 import PlayerFactory from './dist/index';