From 501329c62e59636fb72db3c6ae28a6728de8c30d Mon Sep 17 00:00:00 2001 From: Colin King Date: Wed, 9 Jan 2019 16:54:33 -0800 Subject: [PATCH] Make integrations values more permissive --- types/analytics-node/analytics-node-tests.ts | 14 ++++++++++---- types/analytics-node/index.d.ts | 4 +++- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/types/analytics-node/analytics-node-tests.ts b/types/analytics-node/analytics-node-tests.ts index 6740aaccff..7ad1e372ff 100644 --- a/types/analytics-node/analytics-node-tests.ts +++ b/types/analytics-node/analytics-node-tests.ts @@ -135,22 +135,28 @@ function testGroup(): void { function testIntegrations(): void { analytics.track({ - event: 'Upgraded Membershipt', + event: 'Upgraded Membership', userId: '97234974', integrations: { 'All': false, 'Vero': true, - 'Google Analytics': false + 'Google Analytics': false, + 'AppsFlyer': { + 'appsflyer_id': 'example-id' + } } }); analytics.track({ - event: 'Upgraded Membershipt', + event: 'Upgraded Membership', userId: '97234974', integrations: { 'All': false, 'Vero': true, - 'Google Analytics': false + 'Google Analytics': false, + 'AppsFlyer': { + 'appsflyer_id': 'example-id' + } } }, (err, data) => { if (err) { diff --git a/types/analytics-node/index.d.ts b/types/analytics-node/index.d.ts index cc9e5386e2..7b70f21571 100644 --- a/types/analytics-node/index.d.ts +++ b/types/analytics-node/index.d.ts @@ -33,9 +33,11 @@ declare namespace AnalyticsNode { } interface Integrations { - [index: string]: boolean; + [integration_name: string]: IntegrationValue } + type IntegrationValue = boolean | { [integration_key: string] : any }; + export class Analytics { constructor(writeKey: string, opts?: { flushAt?: number,