From 512edca0d2546308187173ddcc8dc1fb9ca521d7 Mon Sep 17 00:00:00 2001 From: Andy Date: Wed, 20 Dec 2017 06:58:18 -0800 Subject: [PATCH] aurelia-knockout: Provides its own types (#22318) --- notNeededPackages.json | 6 +++++ .../aurelia-knockout-tests.ts | 9 ------- types/aurelia-knockout/index.d.ts | 18 -------------- types/aurelia-knockout/tsconfig.json | 24 ------------------- types/aurelia-knockout/tslint.json | 1 - 5 files changed, 6 insertions(+), 52 deletions(-) delete mode 100644 types/aurelia-knockout/aurelia-knockout-tests.ts delete mode 100644 types/aurelia-knockout/index.d.ts delete mode 100644 types/aurelia-knockout/tsconfig.json delete mode 100644 types/aurelia-knockout/tslint.json diff --git a/notNeededPackages.json b/notNeededPackages.json index 6ccb1e961f..cab0815f31 100644 --- a/notNeededPackages.json +++ b/notNeededPackages.json @@ -60,6 +60,12 @@ "sourceRepoURL": "https://github.com/AlexTeixeira/Askmethat-Rating", "asOfVersion": "0.4.0" }, + { + "libraryName": "aurelia-knockout", + "typingsPackageName": "aurelia-knockout", + "sourceRepoURL": "https://github.com/code-chris/aurelia-knockout", + "asOfVersion": "2.1.0" + }, { "libraryName": "autobind-decorator", "typingsPackageName": "autobind-decorator", diff --git a/types/aurelia-knockout/aurelia-knockout-tests.ts b/types/aurelia-knockout/aurelia-knockout-tests.ts deleted file mode 100644 index cf769d0dc2..0000000000 --- a/types/aurelia-knockout/aurelia-knockout-tests.ts +++ /dev/null @@ -1,9 +0,0 @@ -export class ViewModel { - constructor(private knockoutBindable: KnockoutBindable) { - } - - activate(settings: any): void { - this.knockoutBindable.applyBindableValues(settings, this); - this.knockoutBindable.applyBindableValues(settings, this, true); - } -} diff --git a/types/aurelia-knockout/index.d.ts b/types/aurelia-knockout/index.d.ts deleted file mode 100644 index 6f04567a5f..0000000000 --- a/types/aurelia-knockout/index.d.ts +++ /dev/null @@ -1,18 +0,0 @@ -// Type definitions for aurelia-knockout 2.0 -// Project: https://github.com/code-chris/aurelia-knockout -// Definitions by: Christian Kotzbauer -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - -interface KnockoutBindable { - /** - * Applys all values from a data object (usually the activation data) to the corresponding instance fields - * in the current view model if they are marked as @bindable. By default all matching values from the data object - * are applied. To only apply observable values set the last parameter to `true`. Subscriptions are created - * for all Knockout observables in the data object to update the view-model values respectively. - * - * @param data - the data object - * @param target - the target view model - * @param applyOnlyObservables - `true` if only observable values should be applied, false by default. - */ - applyBindableValues(data: any, target: any, applyOnlyObservables?: boolean): void; -} diff --git a/types/aurelia-knockout/tsconfig.json b/types/aurelia-knockout/tsconfig.json deleted file mode 100644 index ceb4710331..0000000000 --- a/types/aurelia-knockout/tsconfig.json +++ /dev/null @@ -1,24 +0,0 @@ -{ - "compilerOptions": { - "module": "commonjs", - "lib": [ - "es6", - "dom" - ], - "noImplicitAny": true, - "noImplicitThis": true, - "strictNullChecks": false, - "strictFunctionTypes": true, - "baseUrl": "../", - "typeRoots": [ - "../" - ], - "types": [], - "noEmit": true, - "forceConsistentCasingInFileNames": true - }, - "files": [ - "index.d.ts", - "aurelia-knockout-tests.ts" - ] -} \ No newline at end of file diff --git a/types/aurelia-knockout/tslint.json b/types/aurelia-knockout/tslint.json deleted file mode 100644 index 3db14f85ea..0000000000 --- a/types/aurelia-knockout/tslint.json +++ /dev/null @@ -1 +0,0 @@ -{ "extends": "dtslint/dt.json" }