From 52636bbb16cc445f7d18c5b965af9dd12642bb73 Mon Sep 17 00:00:00 2001 From: Mike North Date: Thu, 13 Sep 2018 09:49:42 -0700 Subject: [PATCH] [ember] relax ObserverMethod property name arg (#28839) * [ember] failing test - relax ObserverMethod property name arg * [ember] relax ObserverMethod property name arg --- types/ember/index.d.ts | 2 +- types/ember__utils/ember__utils-tests.ts | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/types/ember/index.d.ts b/types/ember/index.d.ts index cee4ebc780..cbdba8919e 100755 --- a/types/ember/index.d.ts +++ b/types/ember/index.d.ts @@ -143,7 +143,7 @@ declare module 'ember' { type ObserverMethod = | (keyof Target) - | ((this: Target, sender: Sender, key: keyof Sender, value: any, rev: number) => void); + | ((this: Target, sender: Sender, key: string, value: any, rev: number) => void); interface RenderOptions { into?: string; diff --git a/types/ember__utils/ember__utils-tests.ts b/types/ember__utils/ember__utils-tests.ts index d93e2a1ec7..8b270f1bec 100644 --- a/types/ember__utils/ember__utils-tests.ts +++ b/types/ember__utils/ember__utils-tests.ts @@ -8,6 +8,7 @@ import { tryInvoke, typeOf } from '@ember/utils'; +import EmberObject from '@ember/object'; (function() { /** isNone */ @@ -161,3 +162,10 @@ import { isEmpty({ size: 1 }); // $ExpectType boolean isEmpty({ size: () => 0 }); // $ExpectType boolean })(); + +class Foo extends EmberObject.extend({ + abc: true, + bar() { return '123'; } +}) { + def: 'hello'; +}