From 11c07389569c1a11967e7c712e8f6664f87ddfd7 Mon Sep 17 00:00:00 2001 From: Jonathan Hobbs <33226922+jh-pq@users.noreply.github.com> Date: Thu, 20 Dec 2018 10:36:59 +0000 Subject: [PATCH 1/2] fix writeString to have lowercase W Official sources all identify this as `writeString` not `WriteString`. - https://github.com/dcodeIO/bytebuffer.js/blob/master/dist/bytebuffer.js#L2153 - https://github.com/dcodeIO/bytebuffer.js/blob/master/dist/bytebuffer-node.js#L2014 - https://github.com/dcodeIO/bytebuffer.js/wiki/API#bytebufferwritestringstr-offset --- types/bytebuffer/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/bytebuffer/index.d.ts b/types/bytebuffer/index.d.ts index 285948dc24..02098add6a 100644 --- a/types/bytebuffer/index.d.ts +++ b/types/bytebuffer/index.d.ts @@ -582,7 +582,7 @@ declare class ByteBuffer /** * Writes an UTF8 encoded string.This is an alias of ByteBuffer#writeUTF8String. */ - WriteString( str: string, offset?: number ): ByteBuffer | number; + writeString( str: string, offset?: number ): ByteBuffer | number; /** * Writes an UTF8 encoded string. From 34ee62355948c1587826531ab9e8693a2081f908 Mon Sep 17 00:00:00 2001 From: Jonathan Hobbs <33226922+jh-pq@users.noreply.github.com> Date: Thu, 20 Dec 2018 11:22:11 +0000 Subject: [PATCH 2/2] add space after full stop --- types/bytebuffer/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/bytebuffer/index.d.ts b/types/bytebuffer/index.d.ts index 02098add6a..4423d7872b 100644 --- a/types/bytebuffer/index.d.ts +++ b/types/bytebuffer/index.d.ts @@ -580,7 +580,7 @@ declare class ByteBuffer writeShort( value: number, offset?: number ): ByteBuffer; /** - * Writes an UTF8 encoded string.This is an alias of ByteBuffer#writeUTF8String. + * Writes an UTF8 encoded string. This is an alias of ByteBuffer#writeUTF8String. */ writeString( str: string, offset?: number ): ByteBuffer | number;