diff --git a/types/promise.prototype.finally/index.d.ts b/types/promise.prototype.finally/index.d.ts index 9df993ce93..5c4581ba46 100644 --- a/types/promise.prototype.finally/index.d.ts +++ b/types/promise.prototype.finally/index.d.ts @@ -1,11 +1,11 @@ -// Type definitions for promise.prototype.finally v2.0.1 +// Type definitions for promise.prototype.finally 2.0 // Project: https://github.com/matthew-andrews/Promise.prototype.finally // Definitions by: Slava Shpitalny // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare global { interface Promise { - finally(onFinally?: () => U | Promise): Promise; + finally(onFinally?: () => U | PromiseLike): Promise; } } diff --git a/types/promise.prototype.finally/promise.prototype.finally-tests.ts b/types/promise.prototype.finally/promise.prototype.finally-tests.ts index b7f5848606..2fa7c96512 100644 --- a/types/promise.prototype.finally/promise.prototype.finally-tests.ts +++ b/types/promise.prototype.finally/promise.prototype.finally-tests.ts @@ -2,13 +2,14 @@ import promiseFinally = require('promise.prototype.finally'); promiseFinally.shim(); -var promise = new Promise((resolve, reject) => { +let promise = new Promise((resolve, reject) => { resolve(true); }); promise.finally(() => {}); +promise.finally(() => > Promise.resolve()); promise.then(() => {}, () => {}).finally(() => {}); promise.catch(() => {}).finally(() => {}); -var allPromise = Promise.all([promise]); +let allPromise = Promise.all([promise]); allPromise.finally(() => {}); diff --git a/types/promise.prototype.finally/tslint.json b/types/promise.prototype.finally/tslint.json new file mode 100644 index 0000000000..3db14f85ea --- /dev/null +++ b/types/promise.prototype.finally/tslint.json @@ -0,0 +1 @@ +{ "extends": "dtslint/dt.json" }