From 5421f894857e597413a8f81c738c36f3f0ff3f7d Mon Sep 17 00:00:00 2001 From: Daniel Syddall Date: Tue, 19 Feb 2019 13:33:40 +0000 Subject: [PATCH] Set minimum typescript version to 2.3 Add dom lib to tsconfig.json Use absolute import for chart.js Avoid using declare module --- types/vue-chartkick/index.d.ts | 17 +++++++++-------- types/vue-chartkick/tsconfig.json | 3 ++- types/vue-chartkick/vue-chartkick-tests.ts | 2 +- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/types/vue-chartkick/index.d.ts b/types/vue-chartkick/index.d.ts index 6c3cfa6275..79f70d084d 100644 --- a/types/vue-chartkick/index.d.ts +++ b/types/vue-chartkick/index.d.ts @@ -2,13 +2,14 @@ // Project: https://github.com/ankane/vue-chartkick#readme // Definitions by: CNS Media // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 2.3 -declare module "vue-chartkick" { - import {PluginObject} from "vue"; - interface VueChartkickPlugin extends PluginObject<{adapter: any}> { - version: string; - addAdapter: (library: any) => void - } - const VueChartkick: VueChartkickPlugin; - export default VueChartkick; +import { PluginObject } from "vue"; + +interface VueChartkickPlugin extends PluginObject<{ adapter: any }> { + version: string; + addAdapter: (library: any) => void; } + +declare const VueChartkick: VueChartkickPlugin; +export default VueChartkick; diff --git a/types/vue-chartkick/tsconfig.json b/types/vue-chartkick/tsconfig.json index a6330a553d..2d517d3efd 100644 --- a/types/vue-chartkick/tsconfig.json +++ b/types/vue-chartkick/tsconfig.json @@ -2,7 +2,8 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es6" + "es6", + "dom" ], "noImplicitAny": true, "noImplicitThis": true, diff --git a/types/vue-chartkick/vue-chartkick-tests.ts b/types/vue-chartkick/vue-chartkick-tests.ts index 1aa76075df..4f938eb54e 100644 --- a/types/vue-chartkick/vue-chartkick-tests.ts +++ b/types/vue-chartkick/vue-chartkick-tests.ts @@ -1,5 +1,5 @@ import VueChartkick from 'vue-chartkick'; import Vue from "vue"; -import * as Chart from "../chart.js"; +import * as Chart from "chart.js"; Vue.use(VueChartkick, {adapter: Chart});