From 545e576c1cb2c2b685bdc5b4599f20872f57544e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E1=8E=B7=E1=8E=AA=E1=8E=A2=E1=8E=AC=E1=8F=8C=E1=8F=9A?= =?UTF-8?q?=E1=8F=83=20=E1=8E=A2=E1=8F=8C=E1=8E=A1=E1=8F=9F=E1=8F=83?= =?UTF-8?q?=E1=8E=AA?= Date: Mon, 24 Jun 2019 21:51:17 +0200 Subject: [PATCH] [@types/codemirror] Add boolean type to autoCloseBrackets option (#36323) Currently definition for autoCloseBrackets doesn't allow boolean values, which is wrong. Setting autoCloseBrackets to true enables autoclosing feature with the default settings, as is visible in the source code of a demo on the CodeMirror's official website: https://codemirror.net/demo/closebrackets.html var editor = CodeMirror.fromTextArea(document.getElementById("code"), {autoCloseBrackets: true}); --- types/codemirror/addon/edit/closebrackets.d.ts | 2 +- types/codemirror/test/addon/edit/closebrackets.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/types/codemirror/addon/edit/closebrackets.d.ts b/types/codemirror/addon/edit/closebrackets.d.ts index be75ddceff..994789b1c9 100644 --- a/types/codemirror/addon/edit/closebrackets.d.ts +++ b/types/codemirror/addon/edit/closebrackets.d.ts @@ -42,6 +42,6 @@ declare module "codemirror" { * By default, it'll auto-close ()[]{}''"", but you can pass it a string similar to that (containing pairs of matching characters), * or an object with pairs and optionally explode properties to customize it. */ - autoCloseBrackets?: AutoCloseBrackets | string; + autoCloseBrackets?: AutoCloseBrackets | boolean | string; } } diff --git a/types/codemirror/test/addon/edit/closebrackets.ts b/types/codemirror/test/addon/edit/closebrackets.ts index 2ee95dd5cc..fb64ea76f6 100644 --- a/types/codemirror/test/addon/edit/closebrackets.ts +++ b/types/codemirror/test/addon/edit/closebrackets.ts @@ -4,3 +4,7 @@ var myCodeMirror: CodeMirror.Editor = CodeMirror(document.body, { autoCloseBrackets: "()[]{}''\"\"" }); + +var myCodeMirror2: CodeMirror.Editor = CodeMirror(document.body, { + autoCloseBrackets: true +});