From 5731953945ec2d03797a33cab0e8f32d79fa232b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kalvis=20Kalni=C5=86=C5=A1?= Date: Thu, 3 Jan 2019 12:05:54 +0200 Subject: [PATCH] fix: review --- types/socketcluster-server/index.d.ts | 2 +- types/socketcluster-server/scserver.d.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/types/socketcluster-server/index.d.ts b/types/socketcluster-server/index.d.ts index 7466d1daed..17f138bf0f 100644 --- a/types/socketcluster-server/index.d.ts +++ b/types/socketcluster-server/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for socketcluster-server 13.1 +// Type definitions for socketcluster-server 14.2 // Project: https://github.com/SocketCluster/socketcluster-server // Definitions by: Daniel Rose // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped diff --git a/types/socketcluster-server/scserver.d.ts b/types/socketcluster-server/scserver.d.ts index cef90acfed..48952a8a8a 100644 --- a/types/socketcluster-server/scserver.d.ts +++ b/types/socketcluster-server/scserver.d.ts @@ -34,7 +34,7 @@ declare class SCServer extends EventEmitter { on(event: "connection", listener: SCServer.connectionListenerFunction): this; on(event: "ready", listener: () => void): this; - on(event: "error", listener: (error: Error) => void): this; + on(event: "warning" | "error", listener: (error: Error) => void): this; on(event: "disconnection" | "connectionAbort" | "closure", listener: SCServer.disconnectionListenerFunction): this; on(event: "subscription", listener: SCServer.subscriptionListenerFunction): this; on(event: "unsubscription", listener: SCServer.unsubscriptionListenerFunction): this; @@ -323,7 +323,7 @@ declare namespace SCServer { type connectionListenerFunction = (scSocket: SCServerSocket, serverSocketStatus: SCServerSocketStatus) => void; type disconnectionListenerFunction = (scSocket: SCServerSocket, code: number, data: any) => void; type subscriptionListenerFunction = (scSocket: SCServerSocket, name: string, options: {channel: string}) => void; - type unsubscriptionListenerFunction = (scSocket: SCServerSocket, name: string, channel: string) => void; + type unsubscriptionListenerFunction = (scSocket: SCServerSocket, channel: string) => void; type handshakeListenerFunction = (scSocket: SCServerSocket) => void; type badSocketAuthTokenListenerFunction = (scSocket: SCServerSocket, status: badAuthStatus) => void;