From 58f3f0e713d96dd72fa972704ea86de4eda37573 Mon Sep 17 00:00:00 2001
From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Date: Mon, 24 Feb 2020 08:43:46 -0800
Subject: [PATCH] Call uncalled function in d3-selection tests (#42592)

typescript@next has better detection of boolean checks on uncalled
functions. This caught an error in d3-selection's tests.
---
 types/d3-selection/d3-selection-tests.ts | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/types/d3-selection/d3-selection-tests.ts b/types/d3-selection/d3-selection-tests.ts
index 46656119b2..738c1bc2b7 100644
--- a/types/d3-selection/d3-selection-tests.ts
+++ b/types/d3-selection/d3-selection-tests.ts
@@ -1208,37 +1208,37 @@ selTextAndCircle = text.join(enter => enter.append('circle').text(d => d.data));
 
 selText = text.join(
     'text',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.data).remove(),
 );
 
 selText = text.join<SVGTextElement>(
     'custom',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.data).remove(),
 );
 
 selText = text.join(
     enter => enter.append('text').text(d => d.data),
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.data).remove(),
 );
 
 selTextAndCircle = text.join(
     'circle',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.data).remove(),
 );
 
 selTextAndCircle = text.join<SVGCircleElement>(
     'custom',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.data).remove(),
 );
 
 selTextAndCircle = text.join(
     enter => enter.append('circle').text(d => d.data),
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.data).remove(),
 );
 
@@ -1246,37 +1246,37 @@ selTextAndCircle = text.join(
 
 selText = text.join<'text', OldDatum>(
     'text',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => `Bye ${d.oldData}`).remove(),
 );
 
 selText = text.join<SVGTextElement, OldDatum>(
     'custom',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => `Bye ${d.oldData}`).remove(),
 );
 
 selText = text.join<SVGTextElement, OldDatum>(
     enter => enter.append('text').text(d => d.data),
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.oldData).remove(),
 );
 
 selTextAndCircle = text.join<'circle', OldDatum>(
     'circle',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.oldData).remove(),
 );
 
 selTextAndCircle = text.join<SVGCircleElement, OldDatum>(
     'circle',
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.oldData).remove(),
 );
 
 selTextAndCircle = text.join<SVGCircleElement, OldDatum>(
     enter => enter.append('circle').text(d => d.data),
-    update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
+    update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
     exit => exit.text(d => d.oldData).remove(),
 );