From 59c9faf71a1493d43ed142de149dccdd3e42a97f Mon Sep 17 00:00:00 2001 From: Rogier Schouten Date: Sat, 21 Jul 2018 02:31:13 +0200 Subject: [PATCH] fix returntype of publish() and sendToQueue() (#27322) --- .../amqp-connection-manager/amqp-connection-manager-tests.ts | 5 +++++ types/amqp-connection-manager/index.d.ts | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/types/amqp-connection-manager/amqp-connection-manager-tests.ts b/types/amqp-connection-manager/amqp-connection-manager-tests.ts index 0ee1aeaf95..6eae738a3c 100644 --- a/types/amqp-connection-manager/amqp-connection-manager-tests.ts +++ b/types/amqp-connection-manager/amqp-connection-manager-tests.ts @@ -18,3 +18,8 @@ connection.on("disconnect", (_arg: { err: Error }): void => undefined); channelWrapper.on("close", () => undefined); channelWrapper.on("connect", () => undefined); channelWrapper.on("error", (_error: Error) => undefined); + +channelWrapper.sendToQueue("foo", Buffer.from("bar")) + .catch((error: Error): void => { + // nothing + }); diff --git a/types/amqp-connection-manager/index.d.ts b/types/amqp-connection-manager/index.d.ts index e8683a4ed6..ab69aadeb1 100644 --- a/types/amqp-connection-manager/index.d.ts +++ b/types/amqp-connection-manager/index.d.ts @@ -146,7 +146,7 @@ export interface ChannelWrapper extends EventEmitter { * @param options * @param callback */ - publish(exchange: string, routingKey: string, content: Buffer, options?: Options.Publish, callback?: (err: any, ok: Replies.Empty) => void): boolean; + publish(exchange: string, routingKey: string, content: Buffer, options?: Options.Publish, callback?: (err: any, ok: Replies.Empty) => void): Promise; /** * @see amqplib @@ -155,7 +155,7 @@ export interface ChannelWrapper extends EventEmitter { * @param options * @param callback */ - sendToQueue(queue: string, content: Buffer, options?: Options.Publish, callback?: (err: any, ok: Replies.Empty) => void): boolean; + sendToQueue(queue: string, content: Buffer, options?: Options.Publish, callback?: (err: any, ok: Replies.Empty) => void): Promise; /** * @see amqplib