From 971a75763880ddf0964a6e421c6592a9923a2ece Mon Sep 17 00:00:00 2001 From: Felix Fung Date: Fri, 6 Sep 2013 10:51:09 -0400 Subject: [PATCH] D3's Selection.node() returns an HTMLElement d3_documentElement = document.documentElement and d3_select is initialized from a querySelection so node() will only ever return HTMLElement or null. We mistook it for SVGLocatable because of the following in d3-test.js: var box = label.node().getBBox(); But that's a different node() function altogether. --- d3/d3.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d3/d3.d.ts b/d3/d3.d.ts index 6848ba4ddb..53b36d9121 100644 --- a/d3/d3.d.ts +++ b/d3/d3.d.ts @@ -740,7 +740,7 @@ declare module D3 { */ sort(comparator?: (a: T, b: T) => number): Selection; order: () => Selection; - node: () => SVGLocatable; + node: () => HTMLElement; } export interface EnterSelection { @@ -748,7 +748,7 @@ declare module D3 { insert: (name: string, before: string) => Selection; select: (selector: string) => Selection; empty: () => boolean; - node: () => SVGLocatable; + node: () => HTMLElement; } export interface UpdateSelection extends Selection {