From 5d2136af3ea67ec757343f15e033359588e114e0 Mon Sep 17 00:00:00 2001
From: Colin Cheng <zbinlin@gmail.com>
Date: Fri, 28 Jun 2019 02:06:31 +0800
Subject: [PATCH] fix(koa-router): fix `<router>.register` function signature
 (#36280)

---
 types/koa-router/index.d.ts          | 7 +++++--
 types/koa-router/koa-router-tests.ts | 9 ++++++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/types/koa-router/index.d.ts b/types/koa-router/index.d.ts
index b61eb7a199..a5f3ca256d 100644
--- a/types/koa-router/index.d.ts
+++ b/types/koa-router/index.d.ts
@@ -92,6 +92,9 @@ declare namespace Router {
         name: string;
         sensitive?: boolean;
         strict?: boolean;
+        end?: boolean;
+        prefix?: string;
+        ignoreCaptures?: boolean;
     }
 
     export interface IUrlOptionsQuery {
@@ -482,8 +485,8 @@ declare class Router<StateT = any, CustomT = {}> {
     register(
         path: string | RegExp,
         methods: string[],
-        middleware: Router.IMiddleware<StateT, CustomT>,
-        opts?: Object
+        middleware: Router.IMiddleware<StateT, CustomT> | Array<Router.IMiddleware<StateT, CustomT>>,
+        opts?: Router.ILayerOptions,
     ): Router.Layer;
 
     /**
diff --git a/types/koa-router/koa-router-tests.ts b/types/koa-router/koa-router-tests.ts
index 1759504f7b..052e56efba 100644
--- a/types/koa-router/koa-router-tests.ts
+++ b/types/koa-router/koa-router-tests.ts
@@ -187,4 +187,11 @@ router4.head('/foo', middleware2, routeHandler3);
 router4.post('/foo', emptyMiddleware, emptyMiddleware, routeHandler4);
 router4.post('/foo', emptyMiddleware, emptyMiddleware, emptyMiddleware, routeHandler4);
 router4.get('name', '/foo', emptyMiddleware, emptyMiddleware, routeHandler4);
-router4.get('name', '/foo', emptyMiddleware, emptyMiddleware, emptyMiddleware, routeHandler4);
\ No newline at end of file
+router4.get('name', '/foo', emptyMiddleware, emptyMiddleware, emptyMiddleware, routeHandler4);
+
+
+const router5 = new Router();
+router5.register('/foo', ['GET'], middleware1, {
+    name: 'foo',
+});
+router5.register('/bar', ['GET', 'DELETE'], [middleware1, middleware2]);