From e4d1d1b9a4a124e8cdfb0998e4710f34a8943512 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Fri, 17 Aug 2018 11:57:59 +0900 Subject: [PATCH 1/2] [@types/jws] Allow headers to have extra values. --- types/jws/index.d.ts | 1 + types/jws/jws-tests.ts | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/types/jws/index.d.ts b/types/jws/index.d.ts index f384fadefc..030d670f4a 100644 --- a/types/jws/index.d.ts +++ b/types/jws/index.d.ts @@ -149,4 +149,5 @@ export type Algorithm = 'HS256' | 'HS384' | 'HS512' | 'RS256' | export interface Header { alg: Algorithm; + [key: string]: string; } diff --git a/types/jws/jws-tests.ts b/types/jws/jws-tests.ts index d5271b24ca..c6e62378f8 100644 --- a/types/jws/jws-tests.ts +++ b/types/jws/jws-tests.ts @@ -20,6 +20,13 @@ const signature = jws.sign({ secret: 'has a van', }); +// jws.sign with extra header values +const signatureWithHeaderParams = jws.sign({ + header: { alg: 'HS256', foo: 'bar' }, + payload: 'h. jon benjamin', + secret: 'has a van', +}); + // jws.decode const message = jws.decode('djfakdid'); From f62ee2bc692958546a300ce540eee64d2d481941 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Fri, 17 Aug 2018 12:47:02 +0900 Subject: [PATCH 2/2] Use name instead since in this code we use key often for a different meaning. --- types/jws/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/jws/index.d.ts b/types/jws/index.d.ts index 030d670f4a..fdbf1851c4 100644 --- a/types/jws/index.d.ts +++ b/types/jws/index.d.ts @@ -149,5 +149,5 @@ export type Algorithm = 'HS256' | 'HS384' | 'HS512' | 'RS256' | export interface Header { alg: Algorithm; - [key: string]: string; + [name: string]: string; }