From 649d5bedf73aacb632f783b7d4a4e8432c60abfa Mon Sep 17 00:00:00 2001 From: Ben Tesser Date: Thu, 2 Nov 2017 15:44:03 -0400 Subject: [PATCH] Angular-Modal update activate method Support using locals within the activate method. This is documented here https://github.com/btford/angular-modal\#modalserviceactivate --- types/angular-modal/angular-modal-tests.ts | 4 ++++ types/angular-modal/index.d.ts | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/types/angular-modal/angular-modal-tests.ts b/types/angular-modal/angular-modal-tests.ts index edb4d7e6ef..5d2b5557ea 100644 --- a/types/angular-modal/angular-modal-tests.ts +++ b/types/angular-modal/angular-modal-tests.ts @@ -94,6 +94,10 @@ function callingValues() { template: '
' }); modal.activate().then(() => {}, () => {}); + // activating with random locals + modal.activate({name: 'TestName'}).then(() => {}, () => {}); + // activating with genericly typed locals + modal.activate<{name: string}>({name: 'TestName'}).then(() => {}, () => {}); modal.deactivate().then(() => {}, () => {}); var isActive: boolean = modal.active(); } diff --git a/types/angular-modal/index.d.ts b/types/angular-modal/index.d.ts index 40106e955e..823f47233a 100644 --- a/types/angular-modal/index.d.ts +++ b/types/angular-modal/index.d.ts @@ -28,7 +28,8 @@ declare namespace angularModal { } export interface AngularModal { - activate(): angular.IPromise; + activate(locals?: {}): angular.IPromise; + activate(locals: T): angular.IPromise; deactivate(): angular.IPromise; active(): boolean; }