From 64dcd8e53f9da313f5c2f7bcae47a547fca1b917 Mon Sep 17 00:00:00 2001 From: Ian Remmel <1182361+ianwremmel@users.noreply.github.com> Date: Mon, 6 May 2019 11:22:27 -0700 Subject: [PATCH] @types/passport-http: fix unused template param #1 (#35083) * fix(passport-http): use unused template param It looks like this was rigged up so the appropriate callback definition could be inferred, but one detail got missed. * test(passport-http): add tests demonstrating passReqToCallback --- types/passport-http/index.d.ts | 2 +- types/passport-http/passport-http-tests.ts | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/types/passport-http/index.d.ts b/types/passport-http/index.d.ts index f872a7513b..281848576e 100644 --- a/types/passport-http/index.d.ts +++ b/types/passport-http/index.d.ts @@ -12,7 +12,7 @@ import express = require("express"); export interface BasicStrategyOptions { realm?: string; - passReqToCallback?: boolean; + passReqToCallback?: req; } export interface DigestStrategyOptions { diff --git a/types/passport-http/passport-http-tests.ts b/types/passport-http/passport-http-tests.ts index ee728b2d47..dea2e1108e 100644 --- a/types/passport-http/passport-http-tests.ts +++ b/types/passport-http/passport-http-tests.ts @@ -25,6 +25,9 @@ function validateNonce(nonce: string) { function validateParams(nonce: string, cnonce: string, nc: number, opaque: string) { } +new http.BasicStrategy({passReqToCallback: false}, (username, password, done) => {}); +new http.BasicStrategy({passReqToCallback: true}, (req, username, password, done) => {}); + passport.use(new http.BasicStrategy((username, password, done) => { User.findOne({ username,