From 66a936b0a7d461ef93ee782e4090daec76ae2e0b Mon Sep 17 00:00:00 2001
From: Avi Vahl <avi.vahl@wix.com>
Date: Mon, 22 Oct 2018 18:39:09 +0300
Subject: [PATCH] http-proxy-middleware: avoid installing winston as a dep of
 types package (#29678)

* http-proxy-middleware: avoid installing winston as a dep
per https://github.com/Microsoft/dtslint/pull/144

* package.json can be removed completely
since it has no deps
---
 .../http-proxy-middleware-tests.ts            | 33 ++++++++++++++-----
 types/http-proxy-middleware/package.json      |  6 ----
 2 files changed, 24 insertions(+), 15 deletions(-)
 delete mode 100644 types/http-proxy-middleware/package.json

diff --git a/types/http-proxy-middleware/http-proxy-middleware-tests.ts b/types/http-proxy-middleware/http-proxy-middleware-tests.ts
index 9f60f3704d..aae082a956 100644
--- a/types/http-proxy-middleware/http-proxy-middleware-tests.ts
+++ b/types/http-proxy-middleware/http-proxy-middleware-tests.ts
@@ -1,7 +1,6 @@
 import express = require('express');
 import proxy = require('http-proxy-middleware');
 import { IncomingMessage } from "http";
-import * as Winston from "winston";
 
 const options = {
   target: 'http://www.example.org',
@@ -58,20 +57,36 @@ proxy({
 proxy({logLevel: 'debug'});
 
 proxy({
-  logProvider(provider) {
-    return Winston;
+  logProvider() {
+    // provider can be just log()
+    return {
+      log: console.log
+    };
   }
 });
+
 proxy({
   logProvider(provider) {
-    const logger = Winston.createLogger();
+    // customizing/modifying exisiting provider
+    provider.log = console.log;
+    provider.debug = console.log;
+    provider.info = console.info;
+    provider.warn = console.warn;
+    provider.error = console.error;
 
+    return provider;
+  }
+});
+
+proxy({
+  logProvider() {
+    // replacing provider
     return {
-      log: logger.log,
-      debug: logger.debug,
-      info: logger.info,
-      warn: logger.warn,
-      error: logger.error
+      log: console.log,
+      debug: console.log,
+      info: console.info,
+      warn: console.warn,
+      error: console.error
     };
   }
 });
diff --git a/types/http-proxy-middleware/package.json b/types/http-proxy-middleware/package.json
deleted file mode 100644
index 0aa4cf368f..0000000000
--- a/types/http-proxy-middleware/package.json
+++ /dev/null
@@ -1,6 +0,0 @@
-{
-    "private": true,
-    "dependencies": {
-        "winston": "^3.0.0"
-    }
-}