From 689921213eeef94aa9efb85bdf80bc9e0b1cd12d Mon Sep 17 00:00:00 2001
From: Desmond Koh <deskoh.sg@gmail.com>
Date: Tue, 16 Jul 2019 06:24:16 +0800
Subject: [PATCH] Added missing dependencies (#36886)

* Updated @feathersjs/socket-commons

* Fixed linting errors.

* Added type definitions for hook-less service methods.

* Revert "Added type definitions for hook-less service methods."

This reverts commit 14e8062a57f68b7c338ee092fb3e5cfea9e6f226.

See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/34684

* Improved service typings.

* Fixed tests.

* Fixed lint.

* Fixed typo.

* fix: Handle multiple dependent keys

* Updated header

* fix lint errors

* fix lint errors

* Added SOCKET_KEY export.

* Updated header.

* Removed unecessary imports.

* Added missing dependencies.
---
 types/feathersjs__socketio/feathersjs__socketio-tests.ts | 3 +++
 types/feathersjs__socketio/index.d.ts                    | 1 +
 2 files changed, 4 insertions(+)

diff --git a/types/feathersjs__socketio/feathersjs__socketio-tests.ts b/types/feathersjs__socketio/feathersjs__socketio-tests.ts
index e40ec10897..3715b0b3b2 100644
--- a/types/feathersjs__socketio/feathersjs__socketio-tests.ts
+++ b/types/feathersjs__socketio/feathersjs__socketio-tests.ts
@@ -9,4 +9,7 @@ app.configure(feathersSocketIO({}, io => {}));
 app.configure(feathersSocketIO(1337, io => {}));
 app.configure(feathersSocketIO(1337, {}, io => {}));
 
+app.channel('');
+app.publish('', () => undefined);
+
 const key = SOCKET_KEY;
diff --git a/types/feathersjs__socketio/index.d.ts b/types/feathersjs__socketio/index.d.ts
index 67fca942ad..38e0dc8d3e 100644
--- a/types/feathersjs__socketio/index.d.ts
+++ b/types/feathersjs__socketio/index.d.ts
@@ -5,6 +5,7 @@
 // Definitions: https://github.com/feathersjs-ecosystem/feathers-typescript
 // TypeScript Version: 2.8
 
+/// <reference types="feathersjs__socket-commons"/>
 import * as io from 'socket.io';
 
 declare const socketio: FeathersSocketIO;