From e2000f841d10569407c9ba4b981d3971a5432670 Mon Sep 17 00:00:00 2001 From: GlenCFL Date: Thu, 8 Mar 2018 20:20:32 -0500 Subject: [PATCH 1/2] atom: remove jQuery as a dependency. --- types/atom/index.d.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/types/atom/index.d.ts b/types/atom/index.d.ts index 6a68d685a1..f45f209a90 100644 --- a/types/atom/index.d.ts +++ b/types/atom/index.d.ts @@ -9,7 +9,6 @@ // NOTE: only those classes exported within this file should be retain that status below. // https://github.com/atom/atom/blob/v1.24.0/exports/atom.js -/// /// import { ReadStream, WriteStream } from "fs"; @@ -6754,7 +6753,7 @@ export interface Tooltip { enabled: boolean; timeout: number; hoverState: "in"|"out"|null; - element: JQuery|HTMLElement; + element: HTMLElement; getTitle(): string; getTooltipElement(): HTMLElement; From ea5617c0506527093c39dc59e2dd4ed00ac7b688 Mon Sep 17 00:00:00 2001 From: GlenCFL Date: Thu, 8 Mar 2018 23:13:21 -0500 Subject: [PATCH 2/2] atom: add the JQuery compatible type instead of using JQuery. --- types/atom/index.d.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/types/atom/index.d.ts b/types/atom/index.d.ts index f45f209a90..df446d50c3 100644 --- a/types/atom/index.d.ts +++ b/types/atom/index.d.ts @@ -2524,6 +2524,10 @@ export interface TextEditorRegistry { observe(callback: (editor: TextEditor) => void): Disposable; } +export interface JQueryCompatible extends Iterable { + jquery: string; +} + export type TooltipPlacement = |"top"|"bottom"|"left"|"right" |"auto"|"auto top"|"auto bottom"|"auto left"|"auto right"; @@ -2531,7 +2535,7 @@ export type TooltipPlacement = /** Associates tooltips with HTML elements or selectors. */ export interface TooltipManager { /** Add a tooltip to the given element. */ - add(target: HTMLElement, options: { + add(target: HTMLElement | JQueryCompatible, options: { item?: object, } | { title?: string|(() => string),