From 6b7657b69d7f3fdd700c6b9b9ea64a0da1d919ce Mon Sep 17 00:00:00 2001 From: mzsm Date: Tue, 2 Sep 2014 03:54:34 +0900 Subject: [PATCH 1/2] JQuery.one can omit `selector`. (like JQuery.on) --- jquery/jquery.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jquery/jquery.d.ts b/jquery/jquery.d.ts index 1884180fb2..80ca7e3b82 100644 --- a/jquery/jquery.d.ts +++ b/jquery/jquery.d.ts @@ -2806,7 +2806,7 @@ interface JQuery { * @param selector A selector string to filter the descendants of the selected elements that will call the handler. If the selector is null or omitted, the handler is always called when it reaches the selected element. * @param data Data to be passed to the handler in event.data when an event occurs. */ - one(events: { [key: string]: any; }, selector?: string, data?: any): JQuery; + one(events: { [key: string]: any; }, selector?: any, data?: any): JQuery; /** From e7c2d0b916102f5edbfb022f3e5ae6f23ba5d30f Mon Sep 17 00:00:00 2001 From: mzsm Date: Fri, 5 Sep 2014 11:58:03 +0900 Subject: [PATCH 2/2] Add overload JQuery.one and jQuery.on --- jquery/jquery.d.ts | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/jquery/jquery.d.ts b/jquery/jquery.d.ts index 80ca7e3b82..064f6f51a7 100644 --- a/jquery/jquery.d.ts +++ b/jquery/jquery.d.ts @@ -2763,7 +2763,14 @@ interface JQuery { * @param selector A selector string to filter the descendants of the selected elements that will call the handler. If the selector is null or omitted, the handler is always called when it reaches the selected element. * @param data Data to be passed to the handler in event.data when an event occurs. */ - on(events: { [key: string]: any; }, selector?: any, data?: any): JQuery; + on(events: { [key: string]: any; }, selector?: string, data?: any): JQuery; + /** + * Attach an event handler function for one or more events to the selected elements. + * + * @param events An object in which the string keys represent one or more space-separated event types and optional namespaces, and the values represent a handler function to be called for the event(s). + * @param data Data to be passed to the handler in event.data when an event occurs. + */ + on(events: { [key: string]: any; }, data?: any): JQuery; /** * Attach a handler to an event for the elements. The handler is executed at most once per element per event type. @@ -2806,7 +2813,15 @@ interface JQuery { * @param selector A selector string to filter the descendants of the selected elements that will call the handler. If the selector is null or omitted, the handler is always called when it reaches the selected element. * @param data Data to be passed to the handler in event.data when an event occurs. */ - one(events: { [key: string]: any; }, selector?: any, data?: any): JQuery; + one(events: { [key: string]: any; }, selector?: string, data?: any): JQuery; + + /** + * Attach a handler to an event for the elements. The handler is executed at most once per element per event type. + * + * @param events An object in which the string keys represent one or more space-separated event types and optional namespaces, and the values represent a handler function to be called for the event(s). + * @param data Data to be passed to the handler in event.data when an event occurs. + */ + one(events: { [key: string]: any; }, data?: any): JQuery; /**