From 832d3c938aba5c802018e9786ff99d1e03fd6ae6 Mon Sep 17 00:00:00 2001 From: krauseStefan Date: Wed, 2 Nov 2016 18:02:45 +0100 Subject: [PATCH] types(selenium): fix typings error Level class in logging namespace The 'name' and 'value' properties should not be defined as function, they are inplemented using es6 get functions get value() { return this.value_; } see https://github.com/SeleniumHQ/selenium/blob/ba56ad1ae0b98a1fe1efdd2163c62fc847950178/javascript/node/selenium-webdriver/lib/logging.js#L95 --- selenium-webdriver/index.d.ts | 4 ++-- selenium-webdriver/selenium-webdriver-tests.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/selenium-webdriver/index.d.ts b/selenium-webdriver/index.d.ts index 97722de9b6..bda0820ab5 100644 --- a/selenium-webdriver/index.d.ts +++ b/selenium-webdriver/index.d.ts @@ -1777,10 +1777,10 @@ declare namespace webdriver { toString(): string; /** This logger's name. */ - name(): string; + name: string; /** The numeric log level. */ - value(): number; + value: number; /** * Indicates no log messages should be recorded. diff --git a/selenium-webdriver/selenium-webdriver-tests.ts b/selenium-webdriver/selenium-webdriver-tests.ts index 4e3aa348a3..fa0b0a386e 100644 --- a/selenium-webdriver/selenium-webdriver-tests.ts +++ b/selenium-webdriver/selenium-webdriver-tests.ts @@ -849,8 +849,8 @@ function TestLogging() { level = webdriver.logging.Level.SEVERE; level = webdriver.logging.Level.WARNING; - var name: string = level.name(); - var value: number = level.value(); + var name: string = level.name; + var value: number = level.value; var type: string; type = webdriver.logging.Type.BROWSER;