From 73227df0fd0428a0b32e2d41f486b84ed4b851b6 Mon Sep 17 00:00:00 2001 From: Andy Date: Tue, 7 Aug 2018 12:11:07 -0700 Subject: [PATCH] Jquery: change disables in tslint.json to disables in specific files (#27919) --- types/jquery/test/example-tests.ts | 22 ++++++++++++++++++---- types/jquery/test/learn-tests.ts | 4 ++-- types/jquery/test/longdesc-tests.ts | 15 +++++++++++++-- types/jquery/tslint.json | 17 +---------------- 4 files changed, 34 insertions(+), 24 deletions(-) diff --git a/types/jquery/test/example-tests.ts b/types/jquery/test/example-tests.ts index f725cb2bcb..60fbd431bb 100644 --- a/types/jquery/test/example-tests.ts +++ b/types/jquery/test/example-tests.ts @@ -1,3 +1,17 @@ +// tslint:disable:no-arg +// tslint:disable:no-var-keyword +// tslint:disable:object-literal-key-quotes +// tslint:disable:object-literal-shorthand +// tslint:disable:one-variable-per-declaration +// tslint:disable:only-arrow-functions +// tslint:disable:prefer-conditional-expression +// tslint:disable:prefer-const +// tslint:disable:prefer-for-of +// tslint:disable:prefer-switch +// tslint:disable:prefer-template +// tslint:disable:space-within-parens +// tslint:disable:triple-equals + function examples() { function add_0() { $('div').css('border', '2px solid red') @@ -816,7 +830,7 @@ function examples() { var len = kids.addClass('hilite').length; $('#results span:first').text(len); - $('#results span:last').text(( event.target).tagName); + $('#results span:last').text(event.target.tagName); event.preventDefault(); }); @@ -1600,7 +1614,7 @@ function examples() { function event_target_0() { $('body').click(function(event) { - $('#log').html('clicked: ' + ( event.target).nodeName); + $('#log').html('clicked: ' + event.target.nodeName); }); } @@ -2320,8 +2334,8 @@ function examples() { } function jQuery_contains_0() { - $.contains(document.documentElement, document.body); // true - $.contains(document.body, document.documentElement); // false + $.contains(document.documentElement!, document.body); // true + $.contains(document.body, document.documentElement!); // false } function jQuery_data_0() { diff --git a/types/jquery/test/learn-tests.ts b/types/jquery/test/learn-tests.ts index 17fc7cd285..ef52084da5 100644 --- a/types/jquery/test/learn-tests.ts +++ b/types/jquery/test/learn-tests.ts @@ -11,7 +11,7 @@ interface GreenifyPlugin { } jQuery.fn.greenify = function() { - this.css( "color", "green" ); + this.css("color", "green"); }; -jQuery( "a" ).greenify(); // Makes all the links green. +jQuery("a").greenify(); // Makes all the links green. diff --git a/types/jquery/test/longdesc-tests.ts b/types/jquery/test/longdesc-tests.ts index 3405bb83b5..5275191b5b 100644 --- a/types/jquery/test/longdesc-tests.ts +++ b/types/jquery/test/longdesc-tests.ts @@ -1,3 +1,14 @@ +// tslint:disable:no-var-keyword +// tslint:disable:object-literal-key-quotes +// tslint:disable:object-literal-shorthand +// tslint:disable:one-variable-per-declaration +// tslint:disable:only-arrow-functions +// tslint:disable:prefer-const +// tslint:disable:prefer-for-of +// tslint:disable:prefer-template +// tslint:disable:space-within-parens +// tslint:disable:triple-equals + function longdesc() { function add_0() { $('p').add('div').addClass('widget'); @@ -2358,9 +2369,9 @@ function longdesc() { } function toggle_3(display: boolean) { - if (display === true) { + if (display) { $('#foo').show(); - } else if (display === false) { + } else { $('#foo').hide(); } } diff --git a/types/jquery/tslint.json b/types/jquery/tslint.json index 1d12f59138..93e1f3e072 100644 --- a/types/jquery/tslint.json +++ b/types/jquery/tslint.json @@ -7,21 +7,6 @@ "no-declare-current-package": false, "ban-types": false, - "no-arg": false, - "no-boolean-literal-compare": false, - "no-object-literal-type-assertion": false, - "no-unnecessary-type-assertion": false, - "no-var-keyword": false, - "object-literal-key-quotes": false, - "object-literal-shorthand": false, - "one-variable-per-declaration": false, - "only-arrow-functions": false, - "prefer-conditional-expression": false, - "prefer-const": false, - "prefer-for-of": false, - "prefer-switch": false, - "prefer-template": false, - "space-within-parens": false, - "triple-equals": false + "no-object-literal-type-assertion": false } }