From e1b08d63781f745a4446c0f6de76f984e4f4e735 Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Fri, 9 Feb 2018 15:25:55 +0100 Subject: [PATCH 1/4] Add types for 'builtin-modules' --- .../builtin-modules/builtin-modules-tests.ts | 8 +++++++ types/builtin-modules/index.d.ts | 7 ++++++ types/builtin-modules/static.d.ts | 7 ++++++ types/builtin-modules/tsconfig.json | 24 +++++++++++++++++++ types/builtin-modules/tslint.json | 1 + 5 files changed, 47 insertions(+) create mode 100644 types/builtin-modules/builtin-modules-tests.ts create mode 100644 types/builtin-modules/index.d.ts create mode 100644 types/builtin-modules/static.d.ts create mode 100644 types/builtin-modules/tsconfig.json create mode 100644 types/builtin-modules/tslint.json diff --git a/types/builtin-modules/builtin-modules-tests.ts b/types/builtin-modules/builtin-modules-tests.ts new file mode 100644 index 0000000000..dadcb6ea72 --- /dev/null +++ b/types/builtin-modules/builtin-modules-tests.ts @@ -0,0 +1,8 @@ +import * as builtins from 'builtin-modules'; +import * as builtinsStatic from 'builtin-modules/static'; + +let builtin: string = builtins[0]; +builtin = builtinsStatic[0]; + +builtins.push('foo'); // $ExpectError +builtinsStatic.pop('foo'); // $ExpectError diff --git a/types/builtin-modules/index.d.ts b/types/builtin-modules/index.d.ts new file mode 100644 index 0000000000..c65d38d1be --- /dev/null +++ b/types/builtin-modules/index.d.ts @@ -0,0 +1,7 @@ +// Type definitions for builtin-modules 2.0 +// Project: https://github.com/sindresorhus/builtin-modules#readme +// Definitions by: My Self +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +declare const builtinModules: ReadonlyArray; +export = builtinModules; diff --git a/types/builtin-modules/static.d.ts b/types/builtin-modules/static.d.ts new file mode 100644 index 0000000000..a800bfd4f2 --- /dev/null +++ b/types/builtin-modules/static.d.ts @@ -0,0 +1,7 @@ +// Type definitions for builtin-modules 2.0 +// Project: https://github.com/sindresorhus/builtin-modules#readme +// Definitions by: Klaus Meinhardt +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +declare const builtinModules: ReadonlyArray; +export = builtinModules; diff --git a/types/builtin-modules/tsconfig.json b/types/builtin-modules/tsconfig.json new file mode 100644 index 0000000000..caf8ee2451 --- /dev/null +++ b/types/builtin-modules/tsconfig.json @@ -0,0 +1,24 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": true, + "strictFunctionTypes": true, + "esModuleInterop": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "builtin-modules-tests.ts" + ] +} diff --git a/types/builtin-modules/tslint.json b/types/builtin-modules/tslint.json new file mode 100644 index 0000000000..3db14f85ea --- /dev/null +++ b/types/builtin-modules/tslint.json @@ -0,0 +1 @@ +{ "extends": "dtslint/dt.json" } From afc00789f83e1e4c327af8179048ac7a445bbc81 Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Fri, 9 Feb 2018 18:22:54 +0100 Subject: [PATCH 2/4] fix CI? --- types/builtin-modules/tsconfig.json | 1 + 1 file changed, 1 insertion(+) diff --git a/types/builtin-modules/tsconfig.json b/types/builtin-modules/tsconfig.json index caf8ee2451..46a9992dab 100644 --- a/types/builtin-modules/tsconfig.json +++ b/types/builtin-modules/tsconfig.json @@ -19,6 +19,7 @@ }, "files": [ "index.d.ts", + "static.d.ts", "builtin-modules-tests.ts" ] } From 6596c616c8fb22bba0386f5d62a04165150caa9c Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Fri, 9 Feb 2018 18:29:00 +0100 Subject: [PATCH 3/4] fix CI --- types/builtin-modules/static.d.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/types/builtin-modules/static.d.ts b/types/builtin-modules/static.d.ts index a800bfd4f2..1b9dbb78cd 100644 --- a/types/builtin-modules/static.d.ts +++ b/types/builtin-modules/static.d.ts @@ -1,7 +1,2 @@ -// Type definitions for builtin-modules 2.0 -// Project: https://github.com/sindresorhus/builtin-modules#readme -// Definitions by: Klaus Meinhardt -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - declare const builtinModules: ReadonlyArray; export = builtinModules; From 4a944979e2954cafb902241b40b50973a5e91333 Mon Sep 17 00:00:00 2001 From: Klaus Meinhardt Date: Sat, 10 Feb 2018 02:10:11 +0100 Subject: [PATCH 4/4] update header --- types/builtin-modules/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/builtin-modules/index.d.ts b/types/builtin-modules/index.d.ts index c65d38d1be..a800bfd4f2 100644 --- a/types/builtin-modules/index.d.ts +++ b/types/builtin-modules/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for builtin-modules 2.0 // Project: https://github.com/sindresorhus/builtin-modules#readme -// Definitions by: My Self +// Definitions by: Klaus Meinhardt // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare const builtinModules: ReadonlyArray;