From 4a305e5ce7d14ce2c9027d147e4c92febf79bb14 Mon Sep 17 00:00:00 2001 From: saranshkataria Date: Wed, 27 Dec 2017 10:59:53 +0530 Subject: [PATCH 1/4] added type definitions for element-resize-detector --- .../element-resize-detector-tests.ts | 19 +++++ types/element-resize-detector/index.d.ts | 23 ++++++ types/element-resize-detector/tsconfig.json | 24 ++++++ types/element-resize-detector/tslint.json | 79 +++++++++++++++++++ 4 files changed, 145 insertions(+) create mode 100644 types/element-resize-detector/element-resize-detector-tests.ts create mode 100644 types/element-resize-detector/index.d.ts create mode 100644 types/element-resize-detector/tsconfig.json create mode 100644 types/element-resize-detector/tslint.json diff --git a/types/element-resize-detector/element-resize-detector-tests.ts b/types/element-resize-detector/element-resize-detector-tests.ts new file mode 100644 index 0000000000..e59860ad1f --- /dev/null +++ b/types/element-resize-detector/element-resize-detector-tests.ts @@ -0,0 +1,19 @@ +import * as elementResizeDetectorMaker from 'element-resize-detector' + +let erd = elementResizeDetectorMaker({ + strategy: "scroll" + }); + +const testElement: HTMLElement = null; + + erd.listenTo(testElement, function(element) { + var width = element.offsetWidth; + var height = element.offsetHeight; + console.log("Size: " + width + "x" + height); + }); + + erd.removeListener(testElement, (testElement) => {}); + + erd.removeAllListeners(testElement); + + erd.uninstall(testElement); diff --git a/types/element-resize-detector/index.d.ts b/types/element-resize-detector/index.d.ts new file mode 100644 index 0000000000..e7f1659b43 --- /dev/null +++ b/types/element-resize-detector/index.d.ts @@ -0,0 +1,23 @@ +// Type definitions for element-resize-detector 1.1.12 +// Project: https://github.com/wnr/element-resize-detector +// Definitions by: Saransh Kataria +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped + +declare module 'element-resize-detector' { + function elementResizeDetectorMaker(options?: elementResizeDetectorMaker.ErdmOptions) + : elementResizeDetectorMaker.Erd; + + namespace elementResizeDetectorMaker { + interface ErdmOptions { + strategy?: 'scroll' | 'object'; + } + + interface Erd { + listenTo(element: HTMLElement, callback: (elem: HTMLElement) => void): void; + removeListener(element: HTMLElement, callback: (elem: HTMLElement) => void): void; + removeAllListeners(element: HTMLElement): void; + uninstall(element: HTMLElement): void; + } + } + export = elementResizeDetectorMaker; +} diff --git a/types/element-resize-detector/tsconfig.json b/types/element-resize-detector/tsconfig.json new file mode 100644 index 0000000000..9400053488 --- /dev/null +++ b/types/element-resize-detector/tsconfig.json @@ -0,0 +1,24 @@ +{ + "compilerOptions": { + "module": "commonjs", + "lib": [ + "es6", + "dom" + ], + "noImplicitAny": true, + "noImplicitThis": true, + "strictNullChecks": false, + "strictFunctionTypes": true, + "baseUrl": "../", + "typeRoots": [ + "../" + ], + "types": [], + "noEmit": true, + "forceConsistentCasingInFileNames": true + }, + "files": [ + "index.d.ts", + "element-resize-detector-tests.ts" + ] +} diff --git a/types/element-resize-detector/tslint.json b/types/element-resize-detector/tslint.json new file mode 100644 index 0000000000..a41bf5d19a --- /dev/null +++ b/types/element-resize-detector/tslint.json @@ -0,0 +1,79 @@ +{ + "extends": "dtslint/dt.json", + "rules": { + "adjacent-overload-signatures": false, + "array-type": false, + "arrow-return-shorthand": false, + "ban-types": false, + "callable-types": false, + "comment-format": false, + "dt-header": false, + "eofline": false, + "export-just-namespace": false, + "import-spacing": false, + "interface-name": false, + "interface-over-type-literal": false, + "jsdoc-format": false, + "max-line-length": false, + "member-access": false, + "new-parens": false, + "no-any-union": false, + "no-boolean-literal-compare": false, + "no-conditional-assignment": false, + "no-consecutive-blank-lines": false, + "no-construct": false, + "no-declare-current-package": false, + "no-duplicate-imports": false, + "no-duplicate-variable": false, + "no-empty-interface": false, + "no-for-in-array": false, + "no-inferrable-types": false, + "no-internal-module": false, + "no-irregular-whitespace": false, + "no-mergeable-namespace": false, + "no-misused-new": false, + "no-namespace": false, + "no-object-literal-type-assertion": false, + "no-padding": false, + "no-redundant-jsdoc": false, + "no-redundant-jsdoc-2": false, + "no-redundant-undefined": false, + "no-reference-import": false, + "no-relative-import-in-test": false, + "no-self-import": false, + "no-single-declare-module": false, + "no-string-throw": false, + "no-unnecessary-callback-wrapper": false, + "no-unnecessary-class": false, + "no-unnecessary-generics": false, + "no-unnecessary-qualifier": false, + "no-unnecessary-type-assertion": false, + "no-useless-files": false, + "no-var-keyword": false, + "no-var-requires": false, + "no-void-expression": false, + "no-trailing-whitespace": false, + "object-literal-key-quotes": false, + "object-literal-shorthand": false, + "one-line": false, + "one-variable-per-declaration": false, + "only-arrow-functions": false, + "prefer-conditional-expression": false, + "prefer-const": false, + "prefer-declare-function": false, + "prefer-for-of": false, + "prefer-method-signature": false, + "prefer-template": false, + "radix": false, + "semicolon": false, + "space-before-function-paren": false, + "space-within-parens": false, + "strict-export-declare-modifiers": false, + "trim-file": false, + "triple-equals": false, + "typedef-whitespace": false, + "unified-signatures": false, + "void-return": false, + "whitespace": false + } +} From 5d4239dcc57a0bac30d07b5e73578e9d53306572 Mon Sep 17 00:00:00 2001 From: saranshkataria Date: Thu, 28 Dec 2017 09:50:29 +0530 Subject: [PATCH 2/4] removed disabled rules from tslint --- types/element-resize-detector/tslint.json | 78 +---------------------- 1 file changed, 1 insertion(+), 77 deletions(-) diff --git a/types/element-resize-detector/tslint.json b/types/element-resize-detector/tslint.json index a41bf5d19a..f93cf8562a 100644 --- a/types/element-resize-detector/tslint.json +++ b/types/element-resize-detector/tslint.json @@ -1,79 +1,3 @@ { - "extends": "dtslint/dt.json", - "rules": { - "adjacent-overload-signatures": false, - "array-type": false, - "arrow-return-shorthand": false, - "ban-types": false, - "callable-types": false, - "comment-format": false, - "dt-header": false, - "eofline": false, - "export-just-namespace": false, - "import-spacing": false, - "interface-name": false, - "interface-over-type-literal": false, - "jsdoc-format": false, - "max-line-length": false, - "member-access": false, - "new-parens": false, - "no-any-union": false, - "no-boolean-literal-compare": false, - "no-conditional-assignment": false, - "no-consecutive-blank-lines": false, - "no-construct": false, - "no-declare-current-package": false, - "no-duplicate-imports": false, - "no-duplicate-variable": false, - "no-empty-interface": false, - "no-for-in-array": false, - "no-inferrable-types": false, - "no-internal-module": false, - "no-irregular-whitespace": false, - "no-mergeable-namespace": false, - "no-misused-new": false, - "no-namespace": false, - "no-object-literal-type-assertion": false, - "no-padding": false, - "no-redundant-jsdoc": false, - "no-redundant-jsdoc-2": false, - "no-redundant-undefined": false, - "no-reference-import": false, - "no-relative-import-in-test": false, - "no-self-import": false, - "no-single-declare-module": false, - "no-string-throw": false, - "no-unnecessary-callback-wrapper": false, - "no-unnecessary-class": false, - "no-unnecessary-generics": false, - "no-unnecessary-qualifier": false, - "no-unnecessary-type-assertion": false, - "no-useless-files": false, - "no-var-keyword": false, - "no-var-requires": false, - "no-void-expression": false, - "no-trailing-whitespace": false, - "object-literal-key-quotes": false, - "object-literal-shorthand": false, - "one-line": false, - "one-variable-per-declaration": false, - "only-arrow-functions": false, - "prefer-conditional-expression": false, - "prefer-const": false, - "prefer-declare-function": false, - "prefer-for-of": false, - "prefer-method-signature": false, - "prefer-template": false, - "radix": false, - "semicolon": false, - "space-before-function-paren": false, - "space-within-parens": false, - "strict-export-declare-modifiers": false, - "trim-file": false, - "triple-equals": false, - "typedef-whitespace": false, - "unified-signatures": false, - "void-return": false, - "whitespace": false - } + "extends": "dtslint/dt.json" } From 25d9efa9becb2026164e283c7ac4453de69b59c0 Mon Sep 17 00:00:00 2001 From: saranshkataria Date: Thu, 28 Dec 2017 10:02:57 +0530 Subject: [PATCH 3/4] fixed tslint issues --- .../element-resize-detector-tests.ts | 12 ++++----- types/element-resize-detector/index.d.ts | 27 +++++++++---------- 2 files changed, 18 insertions(+), 21 deletions(-) diff --git a/types/element-resize-detector/element-resize-detector-tests.ts b/types/element-resize-detector/element-resize-detector-tests.ts index e59860ad1f..3c7af76280 100644 --- a/types/element-resize-detector/element-resize-detector-tests.ts +++ b/types/element-resize-detector/element-resize-detector-tests.ts @@ -1,15 +1,15 @@ -import * as elementResizeDetectorMaker from 'element-resize-detector' +import * as elementResizeDetectorMaker from 'element-resize-detector'; -let erd = elementResizeDetectorMaker({ +const erd = elementResizeDetectorMaker({ strategy: "scroll" }); const testElement: HTMLElement = null; - erd.listenTo(testElement, function(element) { - var width = element.offsetWidth; - var height = element.offsetHeight; - console.log("Size: " + width + "x" + height); + erd.listenTo(testElement, (element) => { + const width = element.offsetWidth; + const height = element.offsetHeight; + console.log(`Size: " + ${width} + "x" + ${height}`); }); erd.removeListener(testElement, (testElement) => {}); diff --git a/types/element-resize-detector/index.d.ts b/types/element-resize-detector/index.d.ts index e7f1659b43..cfe3141a89 100644 --- a/types/element-resize-detector/index.d.ts +++ b/types/element-resize-detector/index.d.ts @@ -1,23 +1,20 @@ -// Type definitions for element-resize-detector 1.1.12 +// Type definitions for element-resize-detector 1.1 // Project: https://github.com/wnr/element-resize-detector // Definitions by: Saransh Kataria // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -declare module 'element-resize-detector' { - function elementResizeDetectorMaker(options?: elementResizeDetectorMaker.ErdmOptions) - : elementResizeDetectorMaker.Erd; +declare function elementResizeDetectorMaker(options?: elementResizeDetectorMaker.ErdmOptions) : elementResizeDetectorMaker.Erd; - namespace elementResizeDetectorMaker { - interface ErdmOptions { - strategy?: 'scroll' | 'object'; - } +declare namespace elementResizeDetectorMaker { + interface ErdmOptions { + strategy?: 'scroll' | 'object'; + } - interface Erd { - listenTo(element: HTMLElement, callback: (elem: HTMLElement) => void): void; - removeListener(element: HTMLElement, callback: (elem: HTMLElement) => void): void; - removeAllListeners(element: HTMLElement): void; - uninstall(element: HTMLElement): void; - } + interface Erd { + listenTo(element: HTMLElement, callback: (elem: HTMLElement) => void): void; + removeListener(element: HTMLElement, callback: (elem: HTMLElement) => void): void; + removeAllListeners(element: HTMLElement): void; + uninstall(element: HTMLElement): void; } - export = elementResizeDetectorMaker; } +export = elementResizeDetectorMaker; From 03cceeea2d89c8bdc773fe7c5653c8409136ca8c Mon Sep 17 00:00:00 2001 From: saranshkataria Date: Thu, 28 Dec 2017 10:11:33 +0530 Subject: [PATCH 4/4] removed extra whitespace in index file --- types/element-resize-detector/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/element-resize-detector/index.d.ts b/types/element-resize-detector/index.d.ts index cfe3141a89..5b6c1f00aa 100644 --- a/types/element-resize-detector/index.d.ts +++ b/types/element-resize-detector/index.d.ts @@ -3,7 +3,7 @@ // Definitions by: Saransh Kataria // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -declare function elementResizeDetectorMaker(options?: elementResizeDetectorMaker.ErdmOptions) : elementResizeDetectorMaker.Erd; +declare function elementResizeDetectorMaker(options?: elementResizeDetectorMaker.ErdmOptions): elementResizeDetectorMaker.Erd; declare namespace elementResizeDetectorMaker { interface ErdmOptions {