From 7de9b6a2c4ea1c6be6edf3d76ffd84636d427e1e Mon Sep 17 00:00:00 2001 From: Sascha Zarhuber Date: Thu, 3 Oct 2019 22:45:12 +0200 Subject: [PATCH] [nanoid] added missing declarations for v2.1 (#38806) * feat(nanoid): added newly introduced file declarations * feat(nanoid): added new files to tsconfig * chore(nanoid): bumped version number --- types/nanoid/async/random-rn.d.ts | 3 +++ types/nanoid/index-browser.d.ts | 3 +++ types/nanoid/index.d.ts | 3 ++- types/nanoid/nanoid-tests.ts | 24 ++++++++++++++---------- types/nanoid/tsconfig.json | 10 ++++------ 5 files changed, 26 insertions(+), 17 deletions(-) create mode 100644 types/nanoid/async/random-rn.d.ts create mode 100644 types/nanoid/index-browser.d.ts diff --git a/types/nanoid/async/random-rn.d.ts b/types/nanoid/async/random-rn.d.ts new file mode 100644 index 0000000000..0a71036e37 --- /dev/null +++ b/types/nanoid/async/random-rn.d.ts @@ -0,0 +1,3 @@ +declare function random(bytes: number): Promise; + +export = random; diff --git a/types/nanoid/index-browser.d.ts b/types/nanoid/index-browser.d.ts new file mode 100644 index 0000000000..b6a78f8c52 --- /dev/null +++ b/types/nanoid/index-browser.d.ts @@ -0,0 +1,3 @@ +declare function nanoid(size?: number): string; + +export = nanoid; diff --git a/types/nanoid/index.d.ts b/types/nanoid/index.d.ts index faaf54029a..f1095d58ef 100644 --- a/types/nanoid/index.d.ts +++ b/types/nanoid/index.d.ts @@ -1,7 +1,8 @@ -// Type definitions for nanoid 2.0 +// Type definitions for nanoid 2.1 // Project: https://github.com/ai/nanoid // Definitions by: Ruben Schmidmeister // Daniel Zhang +// Sascha Zarhuber // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare function nanoid(size?: number): string; diff --git a/types/nanoid/nanoid-tests.ts b/types/nanoid/nanoid-tests.ts index 610e5570f5..363a354ef6 100644 --- a/types/nanoid/nanoid-tests.ts +++ b/types/nanoid/nanoid-tests.ts @@ -3,6 +3,7 @@ import asyncGenerate = require('nanoid/async/generate'); import asyncRandom = require('nanoid/async/random'); import asyncRandomBrowser = require('nanoid/async/random-browser'); import nanoid = require('nanoid'); +import nanoidBrowser = require('nanoid/index-browser'); import format = require('nanoid/format'); import generate = require('nanoid/generate'); import random = require('nanoid/random'); @@ -10,29 +11,32 @@ import randomBrowser = require('nanoid/random-browser'); import url = require('nanoid/url'); import nanoidAsync = require('nanoid/async/index'); import nanoidAsyncBrowser = require('nanoid/async/index-browser'); +import nanoidAsyncRandomRN = require('nanoid/async/random-rn'); import nanoidNonSecure = require('nanoid/non-secure'); import generateNonSecure = require('nanoid/non-secure/generate'); const _random = (size: number) => [1, 2, 3, 4]; const _asyncRandom = (size: number) => Promise.resolve([1, 2, 3, 4]); -asyncFormat(_asyncRandom, "abcdef", 5).then((id) => console.log(id)); -asyncGenerate('0123456789абвгдеё', 5).then((id) => console.log(id)); -asyncRandom(10).then((id) => console.log(id)); -asyncRandomBrowser(10).then((id) => console.log(id)); +asyncFormat(_asyncRandom, 'abcdef', 5).then(id => console.log(id)); +asyncGenerate('0123456789абвгдеё', 5).then(id => console.log(id)); +asyncRandom(10).then(id => console.log(id)); +asyncRandomBrowser(10).then(id => console.log(id)); nanoid(); nanoid(10); -format(_random, "abcdef", 5); +nanoidBrowser(12); +format(_random, 'abcdef', 5); generate('0123456789абвгдеё', 5); random(10); randomBrowser(10); -nanoidAsync().then((id) => console.log(id)); -nanoidAsync(10).then((id) => console.log(id)); +nanoidAsync().then(id => console.log(id)); +nanoidAsync(10).then(id => console.log(id)); nanoidAsync(null, (error, id) => { - console.log(error, id); + console.log(error, id); }); -nanoidAsyncBrowser().then((id) => console.log(id)); -nanoidAsyncBrowser(10).then((id) => console.log(id)); +nanoidAsyncBrowser().then(id => console.log(id)); +nanoidAsyncBrowser(10).then(id => console.log(id)); +nanoidAsyncRandomRN(10).then(buf => console.log(buf)); nanoidNonSecure(); nanoidNonSecure(10); generateNonSecure('0123456789абвгдеё', 5); diff --git a/types/nanoid/tsconfig.json b/types/nanoid/tsconfig.json index fd0285a21d..976141d432 100644 --- a/types/nanoid/tsconfig.json +++ b/types/nanoid/tsconfig.json @@ -1,16 +1,12 @@ { "compilerOptions": { "module": "commonjs", - "lib": [ - "es6" - ], + "lib": ["es6"], "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": true, "baseUrl": "../", - "typeRoots": [ - "../" - ], + "typeRoots": ["../"], "types": [], "noEmit": true, "forceConsistentCasingInFileNames": true, @@ -24,10 +20,12 @@ "async/index-browser.d.ts", "async/index.d.ts", "async/random-browser.d.ts", + "async/random-rn.d.ts", "async/random.d.ts", "format.d.ts", "generate.d.ts", "index.d.ts", + "index-browser.d.ts", "nanoid-tests.ts", "random-browser.d.ts", "random.d.ts",