From 4416b164dc6319caef2bfdc24ffbbeb074bcf549 Mon Sep 17 00:00:00 2001 From: Daniel Montesinos Date: Wed, 29 Aug 2018 12:50:15 +0200 Subject: [PATCH 1/2] added begin function --- types/xmlbuilder/index.d.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/types/xmlbuilder/index.d.ts b/types/xmlbuilder/index.d.ts index 2115d30754..ec7c0bf83e 100644 --- a/types/xmlbuilder/index.d.ts +++ b/types/xmlbuilder/index.d.ts @@ -3,7 +3,6 @@ // Definitions by: Wallymathieu // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - export = xmlbuilder; declare namespace xmlbuilder { @@ -87,5 +86,6 @@ declare namespace xmlbuilder { u(): XMLElementOrXMLNode; } - function create(nameOrObjSpec: string | { [name:string]: Object }, xmldec?: Object, doctype?: any, options?: Object): XMLElementOrXMLNode; -} + function create(nameOrObjSpec: string | { [name: string]: Object }, xmldec?: Object, doctype?: any, options?: Object): XMLElementOrXMLNode; + function begin(): XMLElementOrXMLNode; +} \ No newline at end of file From e6e15c752b6157c023c0ab45ea85a1a16b9a528c Mon Sep 17 00:00:00 2001 From: Daniel Montesinos Date: Wed, 29 Aug 2018 13:11:28 +0200 Subject: [PATCH 2/2] added test --- types/xmlbuilder/index.d.ts | 2 +- types/xmlbuilder/xmlbuilder-tests.ts | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/types/xmlbuilder/index.d.ts b/types/xmlbuilder/index.d.ts index ec7c0bf83e..acaeddca11 100644 --- a/types/xmlbuilder/index.d.ts +++ b/types/xmlbuilder/index.d.ts @@ -88,4 +88,4 @@ declare namespace xmlbuilder { function create(nameOrObjSpec: string | { [name: string]: Object }, xmldec?: Object, doctype?: any, options?: Object): XMLElementOrXMLNode; function begin(): XMLElementOrXMLNode; -} \ No newline at end of file +} diff --git a/types/xmlbuilder/xmlbuilder-tests.ts b/types/xmlbuilder/xmlbuilder-tests.ts index 8be8f780f9..0364d6fed8 100644 --- a/types/xmlbuilder/xmlbuilder-tests.ts +++ b/types/xmlbuilder/xmlbuilder-tests.ts @@ -1,6 +1,7 @@ import xmlbuilder = require('xmlbuilder'); var xml = xmlbuilder.create; +var doc = xmlbuilder.begin; // https://github.com/oozcitak/xmlbuilder-js/blob/master/test/comment.coffee xml('comment', {}, {}, { headless: true }).comment('<>\'"&\t\n\r').end(); @@ -42,9 +43,12 @@ xml('root') .ele('atttest', 'text') .end(); +// https://github.com/oozcitak/xmlbuilder-js/blob/master/test/basic/begin.coffee +doc().ele('root', { att: 'val' }).ele('test').end(); + xml({ - displayNotification: { - level: 'error', - message: 'an error occurred' - } + displayNotification: { + level: 'error', + message: 'an error occurred' + } }); \ No newline at end of file