From 7e12876f17d4a2b75c90fefc208fa6b7f0f1ed3e Mon Sep 17 00:00:00 2001 From: Nikolaj Kappler Date: Mon, 29 Oct 2018 13:17:00 +0100 Subject: [PATCH] fix strictNullChecks workstream: --- types/tern/test/tern.test.ts | 10 +++++----- types/tern/tsconfig.json | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/types/tern/test/tern.test.ts b/types/tern/test/tern.test.ts index 0e641ac33a..87cfee1ee6 100644 --- a/types/tern/test/tern.test.ts +++ b/types/tern/test/tern.test.ts @@ -1,6 +1,6 @@ import * as tern from "tern"; -const server: tern.Server = null; +const server: tern.Server = null as any; server.request({ query: { @@ -9,7 +9,7 @@ server.request({ end: 0 } }, (error, response) => { - if (response.isProperty) { + if (response && response.isProperty) { // } }); @@ -17,7 +17,7 @@ server.request({ server.request({ }, (error, response) => { // $ExpectError - if (response.isProperty) { + if (response && response.isProperty) { // } }); @@ -40,7 +40,7 @@ server.request({ type: "someUnknownType" } }, (error, response) => { - if (response.abc) { + if (response && response.abc) { // } }); @@ -49,7 +49,7 @@ server.request({ query: undefined }, (error, response) => { // $ExpectError - if (response.isProperty) { + if (response && response.isProperty) { // } }); diff --git a/types/tern/tsconfig.json b/types/tern/tsconfig.json index 2a39303a8e..24e87522b3 100644 --- a/types/tern/tsconfig.json +++ b/types/tern/tsconfig.json @@ -6,7 +6,7 @@ ], "noImplicitAny": true, "noImplicitThis": true, - "strictNullChecks": false, + "strictNullChecks": true, "strictFunctionTypes": true, "baseUrl": "../", "typeRoots": [