From 7e252c06daf333fc7ac981e70307bca1d454e7f7 Mon Sep 17 00:00:00 2001 From: Avindra Goolcharan Date: Tue, 8 Aug 2017 14:29:26 -0400 Subject: [PATCH] sessionConfig.valid: make optional (#18748) `koa-session` does not actually require this validator and will provide a default behavior if its not supplied. see: https://github.com/koajs/session/blob/cb6d2c8448f21f6cf42efdb031798c9608f05602/lib/context.js#L152-L167 --- types/koa-session/index.d.ts | 2 +- types/koa-session/koa-session-tests.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/types/koa-session/index.d.ts b/types/koa-session/index.d.ts index bd31a897e3..ae5e2c48fa 100644 --- a/types/koa-session/index.d.ts +++ b/types/koa-session/index.d.ts @@ -59,7 +59,7 @@ declare namespace session { /** * Hook: valid session value before use it */ - valid(...rest: any[]): void; + valid?(...rest: any[]): void; /** * Hook: before save session diff --git a/types/koa-session/koa-session-tests.ts b/types/koa-session/koa-session-tests.ts index 266cb4b98b..ef3ddc6a09 100644 --- a/types/koa-session/koa-session-tests.ts +++ b/types/koa-session/koa-session-tests.ts @@ -1,5 +1,5 @@ import * as Koa from 'koa'; -import session = require('koa-session'); +import * as session from 'koa-session'; const app = new Koa();