From 8308c4b8f02c76ff3c2e58b10e55e61bc5e59782 Mon Sep 17 00:00:00 2001 From: Mo Abbas Date: Mon, 11 Sep 2017 15:08:54 +1000 Subject: [PATCH 1/3] Update jquery.pnotify - add removeStack to PNotifyConstructor - add positionAll to PNotifyConstructor --- types/jquery.pnotify/index.d.ts | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/types/jquery.pnotify/index.d.ts b/types/jquery.pnotify/index.d.ts index 70946c30ef..0faab32489 100644 --- a/types/jquery.pnotify/index.d.ts +++ b/types/jquery.pnotify/index.d.ts @@ -30,7 +30,6 @@ interface PNotifyLabel { stick?: string; } - interface PNotifyconfirmButton { text?: string; addClass?: string; @@ -192,9 +191,10 @@ interface PNotifyOptions { */ icon?: any; /** - * The animation to use when displaying and hiding the notice. "none", "show", "fade", and "slide" are built in to jQuery. Others require jQuery UI. Use an object with effect_in and effect_out to use different effects. + * The animation to use when displaying and hiding the notice. "none", "show", "fade", and "slide" are built in to jQuery. + * Others require jQuery UI. Use an object with effect_in and effect_out to use different effects. */ - animation?: any; + animation?: boolean | string; /** * Speed at which the notice animates in and out. "slow", "def" or "normal", "fast" or number of milliseconds. */ @@ -323,8 +323,22 @@ interface PNotify { interface PNotifyConstructor { new (options?: PNotifyOptions): PNotify; - + + /** + * Remove all notices. + */ removeAll(): void; + + /** + * Remove all the notices in a stack. + * @param stack + */ + removeStack(stack: PNotifyStack): void; + + /** + * Reposition the notices, optionally animating their movement. + */ + positionAll(animate: string): void } declare var PNotify: PNotifyConstructor; From 5a7735c4b314f63081d198929cddcac31619e0d0 Mon Sep 17 00:00:00 2001 From: Mo Abbas Date: Wed, 13 Sep 2017 10:21:17 +1000 Subject: [PATCH 2/3] - update documentation - remove boolean from animation - make animate optional in positionAll --- types/jquery.pnotify/index.d.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/types/jquery.pnotify/index.d.ts b/types/jquery.pnotify/index.d.ts index 0faab32489..07de33d2d9 100644 --- a/types/jquery.pnotify/index.d.ts +++ b/types/jquery.pnotify/index.d.ts @@ -191,10 +191,10 @@ interface PNotifyOptions { */ icon?: any; /** - * The animation to use when displaying and hiding the notice. "none", "show", "fade", and "slide" are built in to jQuery. - * Others require jQuery UI. Use an object with effect_in and effect_out to use different effects. - */ - animation?: boolean | string; + * The animation to use when displaying and hiding the notice. "none" and "fade" are supported through CSS. + * Others are supported through the Animate module and Animate.css. + */ + animation?: string; /** * Speed at which the notice animates in and out. "slow", "def" or "normal", "fast" or number of milliseconds. */ @@ -338,7 +338,7 @@ interface PNotifyConstructor { /** * Reposition the notices, optionally animating their movement. */ - positionAll(animate: string): void + positionAll(animate?: string): void } declare var PNotify: PNotifyConstructor; From ee3f8191db3b1b4cb341c9b5c54a9fbbe35dbcdf Mon Sep 17 00:00:00 2001 From: Mo Abbas Date: Fri, 15 Sep 2017 12:01:39 +1000 Subject: [PATCH 3/3] change positionAll animate from string to boolean --- types/jquery.pnotify/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/jquery.pnotify/index.d.ts b/types/jquery.pnotify/index.d.ts index 07de33d2d9..2c82c1269a 100644 --- a/types/jquery.pnotify/index.d.ts +++ b/types/jquery.pnotify/index.d.ts @@ -338,7 +338,7 @@ interface PNotifyConstructor { /** * Reposition the notices, optionally animating their movement. */ - positionAll(animate?: string): void + positionAll(animate?: boolean): void } declare var PNotify: PNotifyConstructor;