From 8238de91cf862c700a4ce2daa5ea88f383e68f3c Mon Sep 17 00:00:00 2001 From: Dobes Vandermeer Date: Mon, 23 Sep 2019 10:59:51 -0700 Subject: [PATCH] mongodb: support two argument collection call with options (#38348) You can call the collection() method with a name and options, but no callback, if you want to. --- types/mongodb/index.d.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/types/mongodb/index.d.ts b/types/mongodb/index.d.ts index 3184d28c3a..6f43aa22c9 100644 --- a/types/mongodb/index.d.ts +++ b/types/mongodb/index.d.ts @@ -621,9 +621,8 @@ export class Db extends EventEmitter { /** http://mongodb.github.io/node-mongodb-native/3.1/api/Db.html#admin */ admin(): Admin; /** http://mongodb.github.io/node-mongodb-native/3.1/api/Db.html#collection */ - collection(name: string): Collection; - collection(name: string, callback: MongoCallback>): Collection; - collection(name: string, options: DbCollectionOptions, callback: MongoCallback>): Collection; + collection(name: string, callback?: MongoCallback>): Collection; + collection(name: string, options: DbCollectionOptions, callback?: MongoCallback>): Collection; /** http://mongodb.github.io/node-mongodb-native/3.1/api/Db.html#collections */ collections(): Promise>>; collections(callback: MongoCallback>>): void;