From 82a243caea68d65ea3331f852534363cff90ac4f Mon Sep 17 00:00:00 2001 From: Retsam Date: Thu, 20 Dec 2018 16:20:20 -0500 Subject: [PATCH] Fix issue with computeds and KnockoutObservable The fix for #26700 caused this issue, where a KnockoutComputed inferred as KnockoutObservable when using conditional type inference --- types/knockout/index.d.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/types/knockout/index.d.ts b/types/knockout/index.d.ts index fa0e195788..8bf99b79db 100644 --- a/types/knockout/index.d.ts +++ b/types/knockout/index.d.ts @@ -140,7 +140,7 @@ interface KnockoutSubscribableStatic { interface KnockoutSubscription { /** - * Terminates a subscription + * Terminates a subscription */ dispose(): void; } @@ -213,9 +213,6 @@ interface KnockoutReadonlyComputed extends KnockoutReadonlyObservable { interface KnockoutComputed extends KnockoutReadonlyComputed, KnockoutObservable, KnockoutComputedFunctions { fn: KnockoutComputedFunctions; - // It's possible for 'a' to be undefined, since the equalityComparer is run on the initial - // computation with undefined as the first argument. This is user-relevant for deferred computeds. - equalityComparer(a: T | undefined, b: T): boolean; /** * Manually disposes the computed observable, clearing all subscriptions to dependencies. * This function is useful if you want to stop a computed observable from being updated or want to clean up memory for a