From 72bdc9def83f7e529f3d3b86c58cd9489d9afeef Mon Sep 17 00:00:00 2001 From: Tomohisa Oda Date: Wed, 13 Dec 2017 12:04:58 +0900 Subject: [PATCH 1/4] remove unnecessary method in store interface --- types/express-rate-limit/index.d.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/types/express-rate-limit/index.d.ts b/types/express-rate-limit/index.d.ts index a46e0ed6cc..aba7e53f6d 100644 --- a/types/express-rate-limit/index.d.ts +++ b/types/express-rate-limit/index.d.ts @@ -11,7 +11,6 @@ declare namespace RateLimit { interface Store { incr(key: string, cb: StoreIncrementCallback): void; - resetAll(): void; resetKey(key: string): void; } From 56d87ab6722240eb914811a49765043b5d6c7bc4 Mon Sep 17 00:00:00 2001 From: Tomohisa Oda Date: Wed, 13 Dec 2017 12:09:31 +0900 Subject: [PATCH 2/4] add necessary method in store interface --- types/express-rate-limit/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/express-rate-limit/index.d.ts b/types/express-rate-limit/index.d.ts index aba7e53f6d..67f2c1387c 100644 --- a/types/express-rate-limit/index.d.ts +++ b/types/express-rate-limit/index.d.ts @@ -11,6 +11,7 @@ declare namespace RateLimit { interface Store { incr(key: string, cb: StoreIncrementCallback): void; + decrement(key: string): void; resetKey(key: string): void; } From dbfdd6d085107a9eef9de23a4b5f502b44618df6 Mon Sep 17 00:00:00 2001 From: Tomohisa Oda Date: Wed, 13 Dec 2017 12:10:31 +0900 Subject: [PATCH 3/4] add missing skipFailedRequests as option --- types/express-rate-limit/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/express-rate-limit/index.d.ts b/types/express-rate-limit/index.d.ts index 67f2c1387c..32799cc842 100644 --- a/types/express-rate-limit/index.d.ts +++ b/types/express-rate-limit/index.d.ts @@ -24,6 +24,7 @@ declare namespace RateLimit { max?: number; message?: string; skip?(req: express.Request, res: express.Response): boolean; + skipFailedRequests?: boolean; statusCode?: number; store?: Store; onLimitReached?(req: express.Request, res: express.Response, optionsUsed: Options): void; From 514dc4031a434b361d7fbaa9d427c77fedf50503 Mon Sep 17 00:00:00 2001 From: Tomohisa Oda Date: Wed, 13 Dec 2017 12:12:36 +0900 Subject: [PATCH 4/4] fix test for express-rate-limit --- types/express-rate-limit/express-rate-limit-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/express-rate-limit/express-rate-limit-tests.ts b/types/express-rate-limit/express-rate-limit-tests.ts index 677c46254b..6be714f3bf 100644 --- a/types/express-rate-limit/express-rate-limit-tests.ts +++ b/types/express-rate-limit/express-rate-limit-tests.ts @@ -21,7 +21,7 @@ const callbackWithFewerParams = new RateLimit({ class SomeStore implements RateLimit.Store { incr(key: string, cb: RateLimit.StoreIncrementCallback) { } - resetAll() { } + decrement(key: string) { } resetKey(key: string) { } }