From 8456cf18125d36c7110eedf68a9b6d29505152b2 Mon Sep 17 00:00:00 2001 From: Matt Krick Date: Tue, 29 Jan 2019 17:50:45 -0800 Subject: [PATCH 1/2] fix loadMore call sig, make pageInfo nullable --- types/react-relay/index.d.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/types/react-relay/index.d.ts b/types/react-relay/index.d.ts index acce5bf832..d830d22b18 100644 --- a/types/react-relay/index.d.ts +++ b/types/react-relay/index.d.ts @@ -6,6 +6,7 @@ // Nicolas Pirotte // Cameron Knight // Kaare Hoff Skovgaard +// Matt Krick // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.9 @@ -130,15 +131,14 @@ export interface PageInfo { } export interface ConnectionData { edges?: ReadonlyArray; - pageInfo?: Partial; + pageInfo?: Partial | null; } export type RelayPaginationProp = RelayProp & { hasMore(): boolean; isLoading(): boolean; loadMore( pageSize: number, - callback: (error?: Error) => void, - options?: RefetchOptions + callback?: (error?: Error) => void ): RelayRuntimeTypes.Disposable | undefined | null; refetchConnection( totalCount: number, From c33e3eddfceea9c699c153e0b71c12aab78a1743 Mon Sep 17 00:00:00 2001 From: Matt Krick Date: Wed, 30 Jan 2019 07:50:33 -0800 Subject: [PATCH 2/2] fix loadMore call sig, make pageInfo nullable --- types/react-relay/index.d.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/types/react-relay/index.d.ts b/types/react-relay/index.d.ts index 24e86379bf..2d5146289f 100644 --- a/types/react-relay/index.d.ts +++ b/types/react-relay/index.d.ts @@ -139,7 +139,8 @@ export type RelayPaginationProp = RelayProp & { isLoading(): boolean; loadMore( pageSize: number, - callback?: (error?: Error) => void + callback?: ((error?: Error) => void) | null, + options?: RefetchOptions ): RelayRuntimeTypes.Disposable | undefined | null; refetchConnection( totalCount: number,