From 8876d3c7a862ee91581ba10bd7bdfbfae76a8eb8 Mon Sep 17 00:00:00 2001 From: Nox Date: Wed, 11 Sep 2019 07:35:36 +0200 Subject: [PATCH] Add missing typings (as seen in 7.0.12) (#38057) --- types/minio/index.d.ts | 12 +++++++++--- types/minio/minio-tests.ts | 29 +++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 3 deletions(-) diff --git a/types/minio/index.d.ts b/types/minio/index.d.ts index 6e7df514dc..3cbc5f798e 100644 --- a/types/minio/index.d.ts +++ b/types/minio/index.d.ts @@ -11,6 +11,7 @@ // Import from dependencies import { Stream } from 'stream'; import EventEmitter = NodeJS.EventEmitter; +import { AgentOptions } from 'https'; // Exports only from typings export type Region = 'us-east-1'|'us-west-1'|'us-west-2'|'eu-west-1'|'eu-central-1'|'ap-southeast-1'|'ap-northeast-1'|'ap-southeast-2'|'sa-east-1'|'cn-north-1'|string; @@ -26,6 +27,7 @@ export interface ClientOptions { region?: Region; transport?: any; sessionToken?: string; + partSize?: number; } export interface BucketItemFromList { @@ -103,7 +105,7 @@ export class Client { listObjects(bucketName: string, prefix?: string, recursive?: boolean): BucketStream; - listObjectsV2(bucketName: string, prefix?: string, recursive?: boolean): BucketStream; + listObjectsV2(bucketName: string, prefix?: string, recursive?: boolean, startAfter?: string): BucketStream; listIncompleteUploads(bucketName: string, prefix?: string, recursive?: boolean): BucketStream; @@ -145,11 +147,14 @@ export class Client { presignedUrl(httpMethod: string, bucketName: string, objectName: string, callback: ResultCallback): void; presignedUrl(httpMethod: string, bucketName: string, objectName: string, expiry: number, callback: ResultCallback): void; presignedUrl(httpMethod: string, bucketName: string, objectName: string, expiry: number, reqParams: { [key: string]: any; }, callback: ResultCallback): void; - presignedUrl(httpMethod: string, bucketName: string, objectName: string, expiry?: number, reqParams?: { [key: string]: any; }): Promise; + presignedUrl(httpMethod: string, bucketName: string, objectName: string, expiry: number, reqParams: { [key: string]: any; }, requestDate: Date, callback: ResultCallback): void; + presignedUrl(httpMethod: string, bucketName: string, objectName: string, expiry?: number, reqParams?: { [key: string]: any; }, requestDate?: Date): Promise; presignedGetObject(bucketName: string, objectName: string, callback: ResultCallback): void; presignedGetObject(bucketName: string, objectName: string, expiry: number, callback: ResultCallback): void; - presignedGetObject(bucketName: string, objectName: string, expiry?: number): Promise; + presignedGetObject(bucketName: string, objectName: string, expiry: number, respHeaders: { [key: string]: any; }, callback: ResultCallback): void; + presignedGetObject(bucketName: string, objectName: string, expiry: number, respHeaders: { [key: string]: any; }, requestDate: Date, callback: ResultCallback): void; + presignedGetObject(bucketName: string, objectName: string, expiry?: number, respHeaders?: { [key: string]: any; }, requestDate?: Date): Promise; presignedPutObject(bucketName: string, objectName: string, callback: ResultCallback): void; presignedPutObject(bucketName: string, objectName: string, expiry: number, callback: ResultCallback): void; @@ -179,6 +184,7 @@ export class Client { // Other newPostPolicy(): PostPolicy; + setRequestOptions(otpions: AgentOptions): void; } export namespace Policy { diff --git a/types/minio/minio-tests.ts b/types/minio/minio-tests.ts index f93ce98af5..41ee93bbf4 100644 --- a/types/minio/minio-tests.ts +++ b/types/minio/minio-tests.ts @@ -86,8 +86,37 @@ minio.presignedUrl('GET', 'testBucket', 'hello.jpg', 84600, { prefix: 'data', 'm minio.presignedGetObject('testBucket', 'hello.jpg', (error: Error|null, url: string) => { console.log(error, url); }); minio.presignedGetObject('testBucket', 'hello.jpg', 84600, (error: Error|null, url: string) => { console.log(error, url); }); +minio.presignedGetObject( + 'testBucket', + 'hello.jpg', + 84600, + { 'content-disposition': 'attachment; filename="image.png"' }, + (error: Error | null, url: string) => { + console.log(error, url); + }, +); +minio.presignedGetObject( + 'testBucket', + 'hello.jpg', + 84600, + { 'content-disposition': 'attachment; filename="image.png"' }, + new Date(), + (error: Error | null, url: string) => { + console.log(error, url); + }, +); minio.presignedGetObject('testBucket', 'hello.jpg'); minio.presignedGetObject('testBucket', 'hello.jpg', 84600); +minio.presignedGetObject('testBucket', 'hello.jpg', 84600, { + 'content-disposition': 'attachment; filename="image.png"', +}); +minio.presignedGetObject( + 'testBucket', + 'hello.jpg', + 84600, + { 'content-disposition': 'attachment; filename="image.png"' }, + new Date(), +); minio.presignedPutObject('testBucket', 'hello.jpg', (error: Error|null, url: string) => { console.log(error, url); }); minio.presignedPutObject('testBucket', 'hello.jpg', 84600, (error: Error|null, url: string) => { console.log(error, url); });