From 8908cbdb4545e09aa455ae15259edb293ddb14d1 Mon Sep 17 00:00:00 2001 From: Rafal Sawicki Date: Thu, 4 Apr 2019 11:44:27 +0200 Subject: [PATCH] Change async-retry options to use retry library types Since async-retry is passing options parameter directly to the underlying retry library, option types can be reused from it. --- types/async-retry/async-retry-tests.ts | 1 + types/async-retry/index.d.ts | 12 +++++------- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/types/async-retry/async-retry-tests.ts b/types/async-retry/async-retry-tests.ts index 20dfc62c4b..83b5ac84cf 100644 --- a/types/async-retry/async-retry-tests.ts +++ b/types/async-retry/async-retry-tests.ts @@ -7,6 +7,7 @@ const o: Options = { minTimeout: 3, maxTimeout: 4, randomize: true, + forever: false, onRetry: (e: Error) => 42 }; diff --git a/types/async-retry/index.d.ts b/types/async-retry/index.d.ts index 7c1a2329f1..986f79a10e 100644 --- a/types/async-retry/index.d.ts +++ b/types/async-retry/index.d.ts @@ -1,21 +1,19 @@ -// Type definitions for async-retry 1.3 +// Type definitions for async-retry 1.4 // Project: https://github.com/zeit/async-retry#readme // Definitions by: Albert Wu // Pablo Rodríguez +// Rafał Sawicki // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +import { OperationOptions } from 'retry'; + declare function AsyncRetry( fn: AsyncRetry.RetryFunction, opts: AsyncRetry.Options ): Promise; declare namespace AsyncRetry { - interface Options { - retries?: number; - factor?: number; - minTimeout?: number; - maxTimeout?: number; - randomize?: boolean; + interface Options extends OperationOptions { onRetry?: (e: Error, attempt: number) => any; }