From ee55a6283f2df35400350758a6c957d1e8ce1975 Mon Sep 17 00:00:00 2001 From: Henry Myers Date: Thu, 17 Jan 2019 11:31:39 -0500 Subject: [PATCH 1/2] Add optional context property to SegmentOpts --- types/segment-analytics/index.d.ts | 1 + types/segment-analytics/segment-analytics-tests.ts | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/types/segment-analytics/index.d.ts b/types/segment-analytics/index.d.ts index 4456c36214..3f2e7728b2 100644 --- a/types/segment-analytics/index.d.ts +++ b/types/segment-analytics/index.d.ts @@ -12,6 +12,7 @@ declare namespace SegmentAnalytics { interface SegmentOpts { integrations?: any; anonymousId?: string; + context?: Object; } // The actual analytics.js object diff --git a/types/segment-analytics/segment-analytics-tests.ts b/types/segment-analytics/segment-analytics-tests.ts index a89dadbe39..d8976ed379 100644 --- a/types/segment-analytics/segment-analytics-tests.ts +++ b/types/segment-analytics/segment-analytics-tests.ts @@ -13,6 +13,11 @@ var testProps = { var testOpts = { integrations: { Mixpanel: true + }, + context: { + campaign: { + name: 'Cheese Promo' + } } }; From 48658cccd57a2056e9dcbd354dce5dea79c10738 Mon Sep 17 00:00:00 2001 From: Henry Myers Date: Tue, 22 Jan 2019 14:40:11 -0500 Subject: [PATCH 2/2] Change SegmentOpts context type from Object to object --- types/segment-analytics/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/segment-analytics/index.d.ts b/types/segment-analytics/index.d.ts index 3f2e7728b2..c7d0ffa314 100644 --- a/types/segment-analytics/index.d.ts +++ b/types/segment-analytics/index.d.ts @@ -12,7 +12,7 @@ declare namespace SegmentAnalytics { interface SegmentOpts { integrations?: any; anonymousId?: string; - context?: Object; + context?: object; } // The actual analytics.js object